Skip to content

Move the test suite to the weir-go v0.24.0 option API - #62

Merged
liran merged 5 commits into
mainfrom
feat/sdk-option-api
Nov 5, 2026
Merged

liran merged 5 commits into
mainfrom
feat/sdk-option-api

Conversation

@liran

@liran liran commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

This moves the test suite to the Read, Mutate and Native calls that weir-go v0.24.0 replaced the SDK's API with. SDK options cannot be read outside the SDK, so tests of what a call sends now check it at an in-memory server. One-record crawler and workload calls now share long-lived streams instead of opening their own, so earlier crawler results are not comparable and the RPC count behind timed_business_rpcs_per_adapter_invocation no longer tracks those calls.

The version-skew run keeps working against v0.23.1 through a small previous_sdk adapter, which goes away when the previous pin reaches v0.24.0. Until then the soak and benchmark tests and the native write evidence subtest do not run on the previous SDK, which leaves its MutateStream and query-visible writes untested against a newer server. This also fixes a race in the stream metric checks, which could read the metrics before the server recorded the end of a stream whose call had already returned.

liran added 2 commits November 5, 2026 18:10
The integration tests reach the SDK through sdk_current_test.go and
sdk_previous_test.go, so integration-previous-sdk still runs them on
v0.23.1. Soak and benchmark tests need the current API and stay out of
that run for one release.

A call returns with its last result, before the server may have recorded
the stream's end, so stream metrics now wait for that record.
@liran liran self-assigned this Nov 5, 2026
liran added 3 commits November 5, 2026 18:55
SDK options cannot be read outside the SDK, so the crawler's visibility
tests had fallen back to reading their own config and passed with the
option removed. A recording server now checks visibility and action.
Waiting for the first recorded completion could miss a call that split
across streams. Waiting for no business RPC sees all of them.
@liran
liran merged commit 9124259 into main Nov 5, 2026
5 checks passed
@liran
liran deleted the feat/sdk-option-api branch November 5, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant