Repository navigation
Move the test suite to the weir-go v0.24.0 option API - #62
Merged
Merged
Conversation
The integration tests reach the SDK through sdk_current_test.go and sdk_previous_test.go, so integration-previous-sdk still runs them on v0.23.1. Soak and benchmark tests need the current API and stay out of that run for one release. A call returns with its last result, before the server may have recorded the stream's end, so stream metrics now wait for that record.
SDK options cannot be read outside the SDK, so the crawler's visibility tests had fallen back to reading their own config and passed with the option removed. A recording server now checks visibility and action.
Waiting for the first recorded completion could miss a call that split across streams. Waiting for no business RPC sees all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the test suite to the Read, Mutate and Native calls that weir-go v0.24.0 replaced the SDK's API with. SDK options cannot be read outside the SDK, so tests of what a call sends now check it at an in-memory server. One-record crawler and workload calls now share long-lived streams instead of opening their own, so earlier crawler results are not comparable and the RPC count behind
timed_business_rpcs_per_adapter_invocationno longer tracks those calls.The version-skew run keeps working against v0.23.1 through a small
previous_sdkadapter, which goes away when the previous pin reaches v0.24.0. Until then the soak and benchmark tests and the native write evidence subtest do not run on the previous SDK, which leaves itsMutateStreamand query-visible writes untested against a newer server. This also fixes a race in the stream metric checks, which could read the metrics before the server recorded the end of a stream whose call had already returned.