Repository navigation
Make the README a short, uniform guide for newcomers - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README mixed how to run the tests with long descriptions of each benchmark. It now uses the same seven sections as the other Weir repositories, says who needs this repository and lists the tools and Make targets above a short quick start.
Integration, benchmark, soak and CI detail moved unchanged to
docs/, with headings added.I ran
make prepare,make testandmake integrationlocally on macOS arm64 with Docker and withoutWEIR_TEST_MONGODB_BINARY, the path CI does not use. Remaining gap: a first image download within the 4-minute fixture deadline was not tested, so the quick start pulls the images first.