Repository navigation
Pin Weir v0.3.0 for chart 0.20.0 - #41
Merged
Merged
Conversation
Pins source 56b193a and image sha256:6a84f2b3. MongoDB authentication needs an explicit tls option, and the contract check covers tls=false.
The MongoDB CA file needs tls=true, authentication without tls is rejected, and the contract check now sets the tls=false URI explicitly and covers both rejections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart 0.20.0 deploys Weir v0.3.0 (source 56b193a, image
sha256:6a84f2b3…), the release meant to replace Sink. That server accepts MongoDB SCRAM over an explicittls=falsefor clusters without TLS, so the configuration guide now asks for an explicittlsoption and spells out the plaintext risks, and the contract check validates atls=falseURI against the pinned binary and confirms that a CA file withtls=falseand authentication withouttlsare rejected. The rollout test's soak client stays on weir-tests df28116, since the protocol and weir-go v0.24.1 are unchanged.Validated with
make testagainst a binary built from 56b193a, by running the pinned image'sweir version(v0.3.0, revision 56b193a, amd64 and arm64), and by the kind rollout in CI.