This repository was archived by the owner on Nov 8, 2026. It is now read-only.
Repository navigation
Simplify Dataset internals and document the current SDK contract - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat the current URI and streaming contract as the SDK baseline. Remove old release/migration guidance and a legacy wire assertion, correct the Gateway discovery setting, and clarify returned-write commit boundaries. Dataset now snapshots the immutable LuaProgram value without copying and hashing its source again, uses one optional program field, and joins transport and operation failures directly. This accompanies the server cleanup.
Validated with lint, race tests and unchanged coverage floors (112 tests/subtests), protobuf regeneration and server-contract comparison, plus the current server's isolated Gateway/Engine/Worker quickstart with real MongoDB and Kafka. Existing regressions retain program independence, partial results, callback errors and mutation retry safety. No public API or wire changes.