Repository navigation
Settle codec, Resume, Version and config behavior before the first release - #5
Merged
Merged
Conversation
A decode method on FlowConfig is promoted to any struct embedding it, which then loses its own fields. Removing it needs zero attempts to mean the default rather than unlimited, so UnlimitedAttempts now asks for that.
liran
force-pushed
the
fix/codec-and-doc-gaps
branch
from
November 4, 2026 23:11
abc2ac8 to
58d9de9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the last behaviors that were only documented around, fixed while nothing depends on them. Types built on strings and bytes now encode like strings and bytes.
Resumewith a plain error ends the step instead of rerunning its code.Versionstates the oldest version the code supports, so a stale execution stops rather than taking a branch it never took.FlowConfigdecodes as plain JSON so a struct can embed it, which makes zero attempts mean the default, withUnlimitedAttemptsfor retrying without end.A client's same-ID join stays the default because concurrent callers share a run through it, and
WithErrorIfRunningandIsFlowRunningErrornow make that case visible. Retry settings Temporal cannot run are now errors rather than a flow stuck in Running. Log export also rejects a protocol it cannot send, and its errors name the variable. A running step still learns of cancellation only by callingctx.Heartbeat().