Skip to content

V3: Photocopy layer - #187

Merged
git-chad merged 110 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-photocopy
Oct 1, 2026
Merged

git-chad merged 110 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-photocopy

Conversation

@git-chad

Copy link
Copy Markdown
Collaborator

Stacked on #186. Part of the V3 stack (parent #150); nothing merges to main until the plan is complete.

What

A new Photocopy layer (Core, after Lumen Print). Everything is procedural, with no external textures.

  • Copy: Threshold and Contrast crush tones into toner on paper. Generations makes a copy of a copy, with more blur, shift and crush each time.
  • Toner: uneven fill, speckle (dust on the paper and holes in the black), drum streaks, and misregistration.
  • Paper: grain, fold creases with a lit edge, toner and paper color, or transparent paper.
  • Styles: Office Copy (default), Zine, Fax, Blueprint Copy, Pink Flyer.
  • Runs in the transform role, on the shared blur pyramid.

Tests

bun run check passes. photocopy.mjs adds 67 checks, all passing:

  • Blank paper stays blank, and black becomes solid toner.
  • Full contrast crushes the image; low contrast keeps grays.
  • Speckle, streaks, misregistration, generations and creases.
  • Transparent paper.
  • Editor/runtime parity, history, duplication, save/reopen and export.

The full bun run test:composition suite wasn't run for this push.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
shader-lab Ready Ready Preview Oct 1, 2026 2:04pm UTC

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 3/5

[Medium risk] Adds a new photocopy visual effect layer.

The PR is not yet safe to merge because Photocopy can fill transparent group regions with toner and darken partially transparent output at intermediate Amount values.

Summary

Adds a procedural Photocopy effect to the editor and React runtime, with five styles, layer controls, export support, and composition tests.

  • Transparent-group input and partial-Amount compositing need correction.
  • The zero-Amount rendering cost and duplicate test warrant follow-up.

Reviews (1) · Last reviewed commit: "Add a Photocopy layer: toner, speckle, s..."

Comment thread src/renderer/photocopy-pass.ts
Comment thread src/renderer/photocopy-pass.ts Outdated
Comment thread src/renderer/photocopy-pass.ts
Comment thread tests/composition/photocopy.mjs
…roup failures

Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the
parentId of any retained layer (the audio source) whose parent was removed,
so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the
worst-case cellAt count per fragment is 25 instead of unbounded in the
packed minimum-size, maximum-stroke configuration. Mirrored in the
runtime package.
…e on buttons

Clear the active paint layer when the layer stops being paintable (selection,
mode, visibility or lock change) so Paint never resumes without Edit Paint.
Only preventDefault on Space for non-interactive targets so focused buttons
and links still activate.
Divide the ray and core light by its coverage before blending with the
source so glow over transparent or translucent pixels is not darkened by
being treated as premultiplied. Applied to the runtime mirror too.
…ansforms

Allow shared hard edges for polygons when rotation step and jitter are zero.
Derive extended outlines from the outermost band's offset and rotation via a
shared bandLocal helper, in both the app and runtime copies.
… duplicate test

- Extend the gaussian pyramid to 10 levels so radii up to 400 document pixels keep increasing (app and SDK copies)
- Add a oneOf visibility condition and gate Focus, Focus Range and Center to the modes that read them
- Make the duplicate independence test change a real parameter
Add Mask Feather parameter definition for brush masks so the timeline shows the user-facing label. Update the manual QA Limits paragraph to match the Feather and keyframe contract.
Derive output alpha from the red, green and blue samples so displaced
fringes survive at transparent edges. Skip the blur pyramid when distance
and frost are both zero, in the app and runtime copies.
…est, video benchmark

- Image background keeps the input alpha instead of forcing opaque (editor and runtime passes)
- Duplication check edits the real mode param and asserts both layers
- Add a --dots scenario set (graph, blobs, plexus) to the effect video benchmark
…trols

Mesh drift is scaled to keep each point inside its cell, and each quad
splits along whichever diagonal is interior. Dot and link controls that
Mesh ignores are hidden, via a new oneOf visibility condition.
… style paper, duplicate test

- Un-premultiply ink color in transparent-paper output so alpha coverage is not applied twice (app and SDK pass)
- Show Angle for hatch and squiggle (new oneOf visibility condition); show Cross Angle only in hatch
- Plotter styles also set paper to color
- Duplication test now edits the real mode param and checks both layers
- Scale transparent-paper toner by input alpha so empty pixels stay clear
- Mix Amount in premultiplied space so partial amounts do not darken toner
- Skip the blur pyramid when Amount is zero
- Update a real parameter in the duplicate-independence check
- Mirror the pass changes into the React runtime
@git-chad
git-chad force-pushed the git-chad/v3-plotter branch from 22b32c4 to b6eb17f Compare October 1, 2026 14:03
@git-chad
git-chad force-pushed the git-chad/v3-photocopy branch from a2e17e1 to 0d565d7 Compare October 1, 2026 14:03
@git-chad
git-chad changed the base branch from git-chad/v3-plotter to git-chad/shader-lab-v3-plan October 1, 2026 15:14
@git-chad
git-chad merged commit 0d565d7 into git-chad/shader-lab-v3-plan Oct 1, 2026
4 of 5 checks passed

This branch was successfully deployed

1 active deployment
Preview — 0d565d79 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant