Repository navigation
V3: Glass layer (reeded, hammered, pyramid, hex, frosted) - #183
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the worst-case cellAt count per fragment is 25 instead of unbounded in the packed minimum-size, maximum-stroke configuration. Mirrored in the runtime package.
…e on buttons Clear the active paint layer when the layer stops being paintable (selection, mode, visibility or lock change) so Paint never resumes without Edit Paint. Only preventDefault on Space for non-interactive targets so focused buttons and links still activate.
…fect Add DotGridPass to the editor and SDK inner-effect factories and to the SDK inner-effect allowlist.
Seed is now part of ErosionStyleValues, so changing it flips the style to Custom and applying a style restores its seed.
…note Relief now outputs the sampled source alpha (editor and runtime) instead of forcing 1. The preset note is deduplicated and states that Height From and Amount are not part of a style.
Divide the ray and core light by its coverage before blending with the source so glow over transparent or translucent pixels is not darkened by being treated as premultiplied. Applied to the runtime mirror too.
…ansforms Allow shared hard edges for polygons when rotation step and jitter are zero. Derive extended outlines from the outermost band's offset and rotation via a shared bandLocal helper, in both the app and runtime copies.
…zones, lens and motion
… duplicate test - Extend the gaussian pyramid to 10 levels so radii up to 400 document pixels keep increasing (app and SDK copies) - Add a oneOf visibility condition and gate Focus, Focus Range and Center to the modes that read them - Make the duplicate independence test change a real parameter
Add Mask Feather parameter definition for brush masks so the timeline shows the user-facing label. Update the manual QA Limits paragraph to match the Feather and keyframe contract.
…, hex and frosted
Derive output alpha from the red, green and blue samples so displaced fringes survive at transparent edges. Skip the blur pyramid when distance and frost are both zero, in the app and runtime copies.
git-chad
force-pushed
the
git-chad/v3-brush-feather
branch
from
October 1, 2026 14:03
2a3f6b0 to
bf01183
Compare
git-chad
force-pushed
the
git-chad/v3-glass
branch
from
October 1, 2026 14:03
0d527b2 to
9b10887
Compare
git-chad
changed the base branch from
git-chad/v3-brush-feather
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:14
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #182. Part of the V3 stack (parent #150); nothing merges to
mainuntil the plan is complete.Why
The user called Fluted Glass "terrible" and shared real textured-glass photos as the target (references 26 to 30).
What
A new Glass layer (Distort) replaces Fluted Glass in the add-layer menu. Fluted Glass stays registered for saved projects.
transformrole.The pyramid moved into
renderer/blur-pyramid.ts, shared by Blur and Glass. Blur's 83 checks pass unchanged.Review
The first render looked like plastic: shaded cylinders, glittery frost, bubble-wrap cells. Reducing the surface to thin rims and grooves, making hammered cells shallow facets, and softening the frost brought it close to references 26 to 30. A depth study keeps near forms sharp and sliced while far forms melt behind the flutes.
Tests
bun run checkpasses, and the fullbun run test:compositionsuite passes.glass.mjsadds 97 checks:If Glass reports a failure, the test runner now fails after writing its renders.
Manual check:
tests/composition/GLASS-MANUAL-QA.md.Open
🤖 Generated with Claude Code