Skip to content

V3: Lumen Print effect layer - #174

Merged
git-chad merged 70 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-lumen-print
Oct 1, 2026
Merged

git-chad merged 70 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-lumen-print

Conversation

@git-chad

Copy link
Copy Markdown
Collaborator

Stacked on #173. Part of the V3 stack (parent #150); nothing merges to main until the plan is complete.

What

A new Lumen Print effect layer (Core, after Gradient Map). It consolidates three planned families into one layer (roadmap 3.4): Lumen print, altered photo development (3.2) and burned false color (6.1 #1).

It runs a single pass with one tone pipeline: diffusion → exposure/contrast → solarize around a pivot → edge lines (Mackie rims) → halation → washout into paper with a ragged edge → edge burn → midtone grain → palette LUT. The LUT is shared with Gradient Map.

  • Styles: Lumen (default), Cyanotype, Burned, Sabattier, Washed, Eroded. A style writes every control; editing anything shows Custom.
  • Palette: editable ramp. The right end is the paper color.
  • Cost: 21 texture samples per pixel, no extra targets, no readbacks.

References

I opened 06, 07, 10, 12 and 14 and compared renders of every style on a photo against them:

  • Burned, Sabattier and Washed come close to 07, 12 and 06.
  • Eroded erodes into paper but is flatter and more binary than 14.

Tests

bun run check passes, and the full bun run test:composition suite passes. lumen-print.mjs adds 70 checks:

  • Neutral settings reproduce the input exactly.
  • Amount 0 passes the input through.
  • Solarize with the pivot at 0 produces a negative; at full strength the output peaks at the pivot.
  • Contrast, full washout to paper, grain, and finite output for every style.
  • Editor/runtime parity, history, duplication, save/reopen, shader export and runtime pixel parity.

Manual check: tests/composition/LUMEN-PRINT-MANUAL-QA.md.

Open

  • The user's tuning of defaults and final acceptance.
  • Grain doesn't animate over time.
  • Cost hasn't been measured on native hardware.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
shader-lab Ready Ready Preview Oct 1, 2026 2:04pm UTC

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR should not merge until Lumen Print handles transparent neighborhood samples without bleeding hidden RGB into visible content.

Summary

This PR adds the Lumen Print effect across the editor and React runtime, including its WebGPU pass, styles and controls, persistence/export support, catalog entry, documentation, and composition tests.

  • Implements the tone, diffusion, halation, washout, edge-burn, grain, and palette pipeline in mirrored editor/runtime passes.
  • Adds six style presets and an editable palette control.
  • Integrates the layer into creation, rendering, project export, and runtime configuration.
  • Adds GPU parity, persistence, history, style, and visual-render checks.

Reviews (1) · Last reviewed commit: "Add a Lumen Print effect layer with anal..."

Comment thread src/renderer/lumen-print-pass.ts Resolved
Comment thread src/renderer/lumen-print-pass.ts Resolved
Comment thread src/lib/editor/shader-export.ts Resolved
…roup failures

Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the
parentId of any retained layer (the audio source) whose parent was removed,
so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the
worst-case cellAt count per fragment is 25 instead of unbounded in the
packed minimum-size, maximum-stroke configuration. Mirrored in the
runtime package.
…e on buttons

Clear the active paint layer when the layer stops being paintable (selection,
mode, visibility or lock change) so Paint never resumes without Edit Paint.
Only preventDefault on Space for non-interactive targets so focused buttons
and links still activate.
…th limit

- restore font size when a text handle resize is cancelled
- rotate the edit textarea around the anchor on both axes
- cap in-place text edits at the Text parameter's 600 characters
…bracket mode

Body: the trail ribbon now accumulates the corner-masked bracket stroke instead of the full outline, in both the app and the React runtime copy.
…ait edge readback on export, hide snapped handles, widen export type

- Painted placement falls back to the undrifted anchor when drift would leave the stroke
- Edge placement lays out nothing until the edge field exists and the export prepare step awaits the pending readback
- Annotation target handles are hidden while Snap to Strongest Edge is active
- Add annotations to SupportedShaderExportLayerType
…dges, depth validation

- Keep the Missing depth map warning when the color image finishes loading
- Drive built-in parallax from the composition timeline time in the editor media pass
- Make Depth Edges Stretch cover exposed areas inside the frame when Contain has transparent borders (editor and runtime media passes)
- Drop depth references on non-image layers or non-image assets during import
… fallback

- Weight diffusion, halation and edge samples by alpha so hidden RGB cannot bleed across coverage boundaries
- Fall back to the Lumen palette for malformed stops in editor and runtime
- Add lumen-print to SupportedShaderExportLayerType
- Clarify that styles do not set Amount or Seed
@git-chad
git-chad force-pushed the git-chad/v3-lumen-print branch from d1834f5 to 7ca20cc Compare October 1, 2026 14:02
@git-chad
git-chad changed the base branch from git-chad/v3-depth-parallax to git-chad/shader-lab-v3-plan October 1, 2026 15:13
@git-chad
git-chad merged commit 7ca20cc into git-chad/shader-lab-v3-plan Oct 1, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — 7ca20ccd Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant