Repository navigation
Add customizable dark and light colors to Threshold - #162
Merged
git-chad merged 25 commits intoOct 1, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
This was referenced Sep 17, 2026
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the worst-case cellAt count per fragment is 25 instead of unbounded in the packed minimum-size, maximum-stroke configuration. Mirrored in the runtime package.
…e on buttons Clear the active paint layer when the layer stops being paintable (selection, mode, visibility or lock change) so Paint never resumes without Edit Paint. Only preventDefault on Space for non-interactive targets so focused buttons and links still activate.
git-chad
force-pushed
the
git-chad/v3-cell-paint
branch
from
October 1, 2026 07:04
164cec7 to
73107b7
Compare
git-chad
force-pushed
the
git-chad/v3-threshold-colors
branch
from
October 1, 2026 07:04
76a920f to
76efc85
Compare
git-chad
changed the base branch from
git-chad/v3-cell-paint
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threshold now exposes Dark Color and Light Color, so designers can replace the fixed black/white output with a two-color palette. Defaults and missing-field fallbacks stay black/white. Softness blends the chosen colors; inversion swaps their region assignments while threshold boundaries and noise stay unchanged.
The editor and runtime recolor inside the existing shader pass using two uniforms. No extra pass, render target or source sample is added. Existing alpha and layer-opacity behavior is preserved. Reference 01 (Lovedance red/blue) was reviewed alongside actual blue/pink and blue/red photo renders.
Validation:
bun run checkpasses with the existing three lint warnings..labreimport pass (bun tests/composition/threshold-colors-ui.mjs).bun run test:compositionpasses the complete regression suite. The group hydration fixture now explicitly includes the new black/white defaults; dedicated legacy tests verify missing fields.Stacks onto #161 (
git-chad/v3-cell-paint), ultimately integration #150. No merge into main until V3 is complete. User visual acceptance pending; focused test.