Repository navigation
Add connected photographic regions and perimeter outlines - #160
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
|
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the worst-case cellAt count per fragment is 25 instead of unbounded in the packed minimum-size, maximum-stroke configuration. Mirrored in the runtime package.
git-chad
force-pushed
the
git-chad/v3-photographic-cells
branch
from
October 1, 2026 07:04
8e988df to
b995773
Compare
git-chad
force-pushed
the
git-chad/v3-cell-regions
branch
from
October 1, 2026 07:04
2311e14 to
55f46d5
Compare
git-chad
changed the base branch from
git-chad/v3-photographic-cells
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photographic Cells can now reveal connected, stepped regions and outline their perimeter without drawing every internal cell edge. This follows the bridge silhouette (reference 11) and the white poster's cellular regions (reference 05), while retaining photographic detail inside each shape.
Adds Layout (Regions / Individual Cells), independent Region Size, and Outline (None / Perimeter / Every Cell). Regions uses either a coherent seeded field or interpolated image tones. Perimeter includes holes and staggered rows; its neighbor search adapts to stroke reach and skips distant candidates. At positive Gap, separated cells have individual perimeters. Cutout and Keep Image retain their existing coverage semantics.
New layers start with connected regions, zero gap, and fine pink perimeter outlines. Saved layers and partial runtime configurations keep the earlier cell selection/defaults. Includes conditional controls, a refreshed photographic thumbnail, real hydration/history/export checks, and reference-guided QA notes. Paint selection remains the next slice; Edge Scatter and fine-dot/color curation remain follow-ups. This does not perform subject segmentation or complete the entire poster look.
Stacked on #159 (
git-chad/v3-photographic-cells), under integration #150. Nothing merges to main until V3 is complete.Validation:
bun run checkandbun run test:composition(full frozen baselines plus 154 cell GPU cases, 50 added in this slice)..labexport; inspected photo cutouts on warm white and an exploratory color/halftone composition against references 05/11.User visual acceptance pending. Test: set Layout to Regions, Gap to 0, and Outline to Perimeter. Region Size changes broad patches; Cell Size changes the steps; switching to Every Cell restores interior grid lines. See
tests/composition/PHOTOGRAPHIC-CELLS-MANUAL-QA.mdfor the full test and limits.