Repository navigation
ci: trust selected mise config before demo setup - #2465
Merged
Merged
Conversation
codeforester
commented
Oct 5, 2026
codeforester
left a comment
codeforester
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed against issue #2458 and current head 930a99c. The workflow adds path-scoped mise trust for the checked-out base-demo configuration before setup in both the demo E2E and release-BOM lanes, keeps provider trust separate from Base manifest trust, and adds ordering assertions. Hosted checks are green (22 pass, 0 fail, 0 pending), and GitHub reports MERGEABLE/CLEAN with no conflicts. No blocking findings in this review. Issue #2458 remains open; this PR is ready to merge once the maintainer chooses to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trust only the selected disposable
base-demo/.mise.tomlbefore project setup in the scheduled Base Demo E2E workflow and both immutable release-BOM platform lanes. Keep mise provider trust distinct from Base manifest-command trust, and document the boundary.Issue
Fixes #2458
Validation
git diff --check/Users/rameshhp/.base.d/base/.venv/bin/python -m pytest -q tests/test_github_workflows.py(23 passing)basectl setup --ci base-demoin both workflows.Dependencies
None.