Repository navigation
test: isolate completion parity help probes - #2463
Merged
codeforester merged 3 commits intoOct 5, 2026
Merged
Conversation
codeforester
commented
Oct 5, 2026
codeforester
left a comment
codeforester
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed against issue #2460 and current head a8938ea. The completion-parity fixture now isolates HOME and BASE_CACHE_DIR and supplies values for required selector options before invoking documented leaves; the new assertions cover the release version selectors. Hosted checks are green (22 pass, 0 fail, 0 pending), and GitHub reports MERGEABLE/CLEAN with no conflicts. No blocking findings in this review. Issue #2460 remains open. This PR is correctly stacked on #2462, so it is not independently ready for main until its parent stack is integrated.
Base automatically changed from
bug/2457-20261004-preserve-help-passthrough-args
to
main
October 5, 2026 09:21
codeforester
deleted the
ci/2460-20261004-isolate-completion-parity-help-probes
branch
October 5, 2026 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the completion parity suite self-contained by isolating
HOMEandBASE_CACHE_DIR, and derive valid help probes for documented selector options such asrelease check --version <version>.Issue
Fixes #2460
Validation
git diff --checkBASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats --filter "documented public leaves" lib/shell/completions/tests/completions.bats(2 passing)Dependencies
Stacks on #2462 /
bug/2457-20261004-preserve-help-passthrough-args.