Skip to content

Add warn-only governance checks and an expiring maintainer override record #2682

Open

Description

@codeforester

Problem

The accepted Base governance design and implementation plan identify package 19 as a required deliverable. This issue translates that package into a reviewed, bounded issue/PR train; it does not authorize implementation before the issue reaches Ready.

Expected behavior

Implement warn-only lifecycle checks with no merge block, no rollback/reversion, and no automated status mutation. Provide a scoped, reasoned and expiring maintainer override record; agents must not write or approve overrides. Keep automated execution disabled until package 20 pins a released checker.

Scope and non-goals

Scope: Implement warn-only lifecycle checks with no merge block, no rollback/reversion, and no automated status mutation. Provide a scoped, reasoned and expiring maintainer override record; agents must not write or approve overrides. Keep automated execution disabled until package 20 pins a released checker.

Non-goals: Do not silently expand scope, activate unreviewed policy, mirror issue fields onto PRs, grant agents merge/release authority, or make changes outside the named affected areas. Any new product decision or materially new work gets a separate issue and decision record.

Affected areas

Impact and evidence

  1. Product intent: Implements only the accepted governance design and plan; any product-requirement change must be filed separately.
  2. Architecture and contracts: Destination is the package-specific section of the merged governance design/implementation plan plus the affected canonical contract named above.
  3. User guidance: The issue identifies likely guidance paths; the implementation PR must name updated user/FAQ/README paths or give a change-specific reason why none is affected.
  4. CLI/API and reference: The affected-area list determines whether CLI/API/reference docs change; the implementation PR must cite the exact reference path or justify no impact.
  5. Operations and safety: No privileged automation or merge authority is implied; the PR must list operational/security effects and any rollback.
  6. Validation and testing: The issue lists the planned tests; the PR must report executed validation and explain any unavailable test.
  7. Examples and downstream use: The implementation PR must identify affected examples/consumers or give evidence that this change has no downstream surface.
  8. Governance and contributor process: This package changes or preserves the contributor/governance contract as described in Scope; links must point to the canonical rules.
  9. Decision records: No new decision is accepted by this issue; any durable deviation requires a proposed decision record and explicit maintainer acceptance.
  10. Release notes: The PR must include a user-facing release-note line or a reasoned none; this issue does not pre-decide that disposition.

These are issue-stage dispositions to refine during Triage. Before Ready, every category must have its exact destination or evidence-based no-impact reason; the PR repeats the ten-category evidence for actual changes.

Open questions

  • None known. If implementation exposes an unresolved contract, return this issue to Triage and record the decision before implementation continues.

Plan

  • S1: One focused PR for this issue. Use Fixes #N only if no additional slice is needed; if the maintainer approves multiple PRs, name each S1…Sn here before the first is opened and use Part of #N.
  • Dependencies: the P7c issue, the P9 issue
  • Acceptance criteria:
  • Every rule starts warn-only and reports stable evidence/identifiers without blocking or reverting work.
  • Overrides name the maintainer, reason, scope, expiry and rule; agent-produced text cannot grant an override.
  • No issue status, branch, PR, release or policy changes are written by this package.
  • Docs explain how to review warnings and withdraw/expire an override.
  • Validation:
  • Fixtures prove warnings do not fail required checks or mutate GitHub state.
  • Test valid, expired, malformed and agent-authored override attempts.
  • Verify no hosted execution occurs before the pin gate in package 20.
  • Risks and rollback: A warning can be mistaken for approval; label it non-authoritative and keep rules disabled or warn-only until promoted with evidence.
  • Decision impact: No decision is accepted merely by implementing the issue. Record the relevant accepted decision/ADR and file a superseding record if the maintainer approves a change.

Activity

  1. self-assigned this
    on Nov 10, 2026
  2. added
    ciContinuous integration, tests, automation, or release workflows
    on Nov 10, 2026
  3. added this to the v1.11.0 milestone on Nov 11, 2026
  4. codeforester commented on Nov 11, 2026

    @codeforester
    CollaboratorAuthor

    Pre-Triage review against the accepted plan (#2664, tracker #2665)

    1. Missing dependencies: Validate issue readiness through API and CLI intake #2571 and Validate pull request impact, acceptance and release-note evidence #2572. Package 19 depends on all of package 7, and the lifecycle checks include the readiness and PR-body validators. Add both as blocked-by links.
    2. Overrides can't be verified yet. The criterion "agent-produced text cannot grant an override" can't be tested while agents and the maintainer share codeforester. Either use a mechanism only the maintainer can trigger, or state that overrides are audit-only during the single-account period. Also link the authority question to the #2555 crosswalk.
    3. Release boundary. This issue has to ship in a Base release that Pin the released governance checker and promote rules from evidence #2683 then pins, so the two can't close in the same release.

    Dependencies text. Replace the P7c issue, the P9 issue with #2673 and #2674, and add #2571 and #2572. The native blocked-by links are already correct; the body is what a reviewer reads.

    Contract text. The Impact, Scope and Open questions sections are still the shared template text. The Impact section is identical in 24 of #2666–#2690, and Scope repeats Expected behavior. That's fine in Backlog. Before Ready, replace each with this issue's own dispositions.

    Claude Code (Opus 5.5), reviewing from Ramesh's account at his request. This review comes before Triage, so it is not an issue-loop round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ciContinuous integration, tests, automation, or release workflows

Type

Projects

  • Status
    Backlog

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions