Repository navigation
Description
Problem
The accepted Base governance implementation plan assigns this existing issue to package 21b. Its previous scope no longer matches the accepted review-loop and automation boundaries, so this issue has been reconciled to a bounded deliverable and remains in Triage/Backlog until independently reviewed.
Expected behavior
Replace the draft-PR proposal with a least-privilege read-only reviewer pilot. Read an exact issue, PR head SHA, diff, tests and approved reviewer rules; post evidence-backed findings only. Do not execute untrusted code or workflows, access secrets, edit contents, create branches/draft PRs, change Project/status/labels, approve, merge, release or modify policy. Require package 2599's threat review and the accepted pinned-check gate.
Scope and non-goals
Scope: Replace the draft-PR proposal with a least-privilege read-only reviewer pilot. Read an exact issue, PR head SHA, diff, tests and approved reviewer rules; post evidence-backed findings only. Do not execute untrusted code or workflows, access secrets, edit contents, create branches/draft PRs, change Project/status/labels, approve, merge, release or modify policy. Require package 2599's threat review and the accepted pinned-check gate.
Non-goals: Do not use the rejected Agent Assignment/autonomy state machine; do not expand authority or silently change the accepted design; do not activate enforcement or make status/merge changes before the required gates.
Affected areas
- Read-only reviewer workflow/app, issue/PR comment surface, security docs and reviewer rules.
- Accepted source: governance design and implementation plan, PR #2664
- Parent tracker: #2665
Impact and evidence
- Product intent: Implements the accepted governance design; no product-requirement change is authorized here.
- Architecture and contracts: Destination: package 21b of the accepted plan in PR Revise the Base ecosystem governance design and implementation plan #2664, plus the named issue contract.
- User guidance: Likely destinations: Read-only reviewer workflow/app, issue/PR comment surface, security docs and reviewer rules.; the implementation PR must name exact paths or provide a change-specific no-impact reason.
- CLI/API and reference: Update the applicable reference if behavior/commands change; otherwise the implementation PR states why no CLI/API surface is affected.
- Operations and safety: The scope states its authority boundary and rollback; no merge/release authority is implied.
- Validation and testing: Validation steps are listed below; the PR records executed evidence and explains unavailable checks.
- Examples and downstream use: The PR identifies affected examples/consumers or gives a scoped repository search as evidence of no impact.
- Governance and contributor process: This issue applies the accepted process rule and does not duplicate Project fields in the body.
- Decision records: No new decision is accepted by this issue; any deviation requires explicit maintainer approval and a superseding record.
- Release notes: The PR includes a release-note line or a reasoned
none; no user-facing release claim is pre-approved here.
These are issue-stage dispositions; refine exact paths and evidence in Triage before Ready. The implementation PR repeats the ten categories against the actual diff.
Open questions
- None beyond the scope-specific gates above. If evidence changes the accepted contract, return to Triage and obtain a separate maintainer decision.
Plan
- S1: One focused PR for this issue. Use
Fixes #Nif single-PR; if a maintainer approves more than one PR, name slicesS1…Snbefore opening them and usePart of #N. - Dependencies: #2599, #2675, #2677, #2678, #2679, #2680, #2683
- Acceptance criteria:
- The pilot records exact issue/PR revisions, head SHA, tool/model/session, rule-set version and citations for every finding.
- The reviewer can only read repository content and publish findings; no content, branch, status, Project, label, merge or release mutation is possible.
- No PR code, workflow, tests, artifacts or instructions are executed in a privileged context; no secrets are passed.
- Security fixtures in Review the read-only governance agent threat model and permissions #2599 pass, and the pilot can be disabled immediately without changing normal PR flow.
- Findings create or link issues; the reviewer does not silently edit policy or docs.
- Validation:
- Run a controlled repository pilot with benign and adversarial fixtures.
- Verify permissions by attempting denied operations and confirming no execution/secret access.
- Check provenance completeness and kill-switch behavior.
- Risks and rollback: A model can be manipulated by repository content; isolate it, keep permissions minimal, bind to exact revisions, and disable it on any authority leak.
- Decision impact: No decision is accepted by implementation alone; record accepted decisions and file a superseding ADR if a change is approved.
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsBacklog
Activity
[-]feat: agent controller L2 - verify and propose (draft PR)[/-][+]Pilot a read-only reviewer on exact issue and pull request revisions[/+]