Skip to content

docs: review and auto-merge tier policy for allow-listed PR classes #2574

Closed as not planned

Description

@codeforester

Goal

State which pull request classes may be merged without human review and which never may.

Background

main requires zero approving reviews and two checks (base/issue-branch-policy, Core product validation), consistent with the solo-maintainer position. An agent loop beyond draft PRs needs an explicit allow-list, otherwise autonomy is decided ad hoc.

Next-release planning review of 2026-10-14/15 against main at 7faf6dfb. Tracking: #2555.

Prerequisites: #2573.

Scope

  • Define allow-listed classes (for example docs-only, test-only, automated dependency-pin bumps) and never-auto classes (workflows, rulesets, release, trust, installer, security).
  • Provide a path-based classification function with tests, for use by the loop.
  • Document the relationship to docs/review-governance.md and the second-reviewer plan.

Acceptance Criteria

  • Policy is documented.
  • Classifier has fixtures for each class and for mixed PRs (strictest class wins).
  • No change to branch protection settings.

Validation

BASE_CLI_SOURCE_DIR=../base-cli/lib/python \
PYTHONPATH=../base-cli/lib/python:lib/python:cli/python \
python -m pytest <new classifier tests>
git diff --check

Non-Goals

  • Do not enable auto-merge.
  • Do not weaken review requirements.

Project Fields

  • Status: Backlog
  • Priority: P2
  • Area: Docs
  • Initiative: Agentic Coding Platform
  • Size: S
  • Milestone: v1.13.0
  • Category: documentation

Agent Assignment

Assignee: codeforester. Blocked on #2573.

Plan revision (2026-10-16)

This issue is intentionally scheduled for v1.13.0. #2573 remains a prerequisite and #2599 is the security/authority input. The policy must explicitly classify security, credentials, trust, installer, workflow/ruleset, release, and MCP changes as never-auto classes, and must state that an allow-listed path classifier cannot override a sensitive-file or mixed-change finding. This policy is required before any autonomy beyond draft PR preparation; it does not enable auto-merge in this release train.

Activity

  1. added this to the v1.12.0 milestone on Oct 15, 2026
  2. self-assigned this
    on Oct 15, 2026
  3. moved this to Backlog in baseon Oct 15, 2026
  4. modified the milestones: v1.12.0, v1.13.0 on Oct 16, 2026
  5. codeforester commented on Nov 8, 2026

    @codeforester
    CollaboratorAuthor

    On hold: don't start implementation yet.

    The governance design review (#2663, PR #2664) recommends closing this as superseded. The design has every PR reviewed and merged by the maintainer, and auto-merge is out of scope. The never-automatic class list in this issue would move into the planned path-to-area map. Ramesh will decide after Codex responds in this thread.

    Relayed by Claude Code (Opus 5.5) from Ramesh's answers, posting from Ramesh's account.

  6. codeforester commented on Nov 9, 2026

    @codeforester
    CollaboratorAuthor

    Superseded by the accepted governance design in #2664. The design requires a human maintainer to merge every PR, so an allow-list for merging without human review is no longer part of the policy. The sensitive-path and never-automatic boundaries remain in scope for implementation under work packages 9 and 21.

  7. moved this from Backlog to Done in baseon Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationDocumentation improvements

Type

No type

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions