Repository navigation
fix(services): reject orphaned process health checks - #339
Merged
codeforester merged 3 commits intoOct 6, 2026
Merged
codeforester merged 3 commits into
codeforester merged 3 commits into
Conversation
codeforester
force-pushed
the
ci/327-20261005-add-workspace-update-scenarios
branch
from
October 6, 2026 02:38
327182e to
f627c13
Compare
codeforester
force-pushed
the
bug/331-20261006-reject-process-health-checks-without-a-process-lifecycle-con
branch
from
October 6, 2026 02:38
189715c to
3a91c63
Compare
codeforester
force-pushed
the
ci/327-20261005-add-workspace-update-scenarios
branch
from
October 6, 2026 12:54
f627c13 to
0633a34
Compare
codeforester
force-pushed
the
bug/331-20261006-reject-process-health-checks-without-a-process-lifecycle-con
branch
from
October 6, 2026 12:54
3a91c63 to
71f288f
Compare
codeforester
commented
Oct 6, 2026
codeforester
left a comment
codeforester
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed head 71f288f against #331 (stacked on #337). No findings. check.type: process now requires lifecycle.type: process in both places: catalog validation (validate_service_catalog raises a precise ValueError, and the CLI exits 2 without a traceback) and runtime (check_service returns process:missing lifecycle instead of reporting a lifecycle-less service as process:running). Both the CLI and direct-API tests are included, the repo's own catalog still validates, and CI is green (7/7). Ready in stack order.
codeforester
force-pushed
the
ci/327-20261005-add-workspace-update-scenarios
branch
from
October 6, 2026 13:24
0633a34 to
42c352f
Compare
codeforester
force-pushed
the
bug/331-20261006-reject-process-health-checks-without-a-process-lifecycle-con
branch
from
October 6, 2026 13:25
71f288f to
87f20fc
Compare
Base automatically changed from
ci/327-20261005-add-workspace-update-scenarios
to
main
October 6, 2026 14:27
codeforester
deleted the
bug/331-20261006-reject-process-health-checks-without-a-process-lifecycle-con
branch
October 6, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject process health checks that lack a matching process lifecycle contract, and keep the runtime helper fail-closed if it is called directly with an orphaned process check.
Fixes #331
Validation
bats tests/services_test.bats --filter 'process checks without|catalog validator'python3 -m compileall -q bin testsgit diff --checkThe focused tests cover the public status command and the direct catalog-validation API. The complete service suite remains subject to the repository's known local
/bin/pssandbox limitation; hosted validation is required for the full lifecycle matrix.