You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review: not ready; 4 CI jobs fail (Click 8.1 / Python 3.10 and 3.14) on test_logging_sidecar_io_failure_does_not_fail_attached_json_command. Under Click 8.1 result.output holds stdout only, so assert "logging persistence failed" in result.output fails (output was just the JSON envelope). Assert on result.stderr as the other new tests do.
The production change looks right (non-recursive diagnostic, process-control exceptions preserved, close() hardened). Non-blocking: every failing record now writes a stderr line, so a persistently broken sidecar will print one line per log call; consider emitting once per handler. The tests also reach into private handler state (_lock_stream, _lock_identity), which is brittle; a small test helper would help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #410. Keeps ordinary sidecar open, lock, unlock, and close failures inside a non-recursive diagnostic boundary while preserving process-control exceptions. Tests: tests/test_logging_hot_path.py.