Repository navigation
ci: require consumer and compatibility checks before merging demo changes #27
Description
Problem
The demo has useful hosted checks, but none are required by the effective main-branch rules. Contributors can merge broken learning examples or incompatible consumers while preserving the appearance of a validated reference application.
Verified evidence
Reviewed on 2026-09-12 at 2de6b83f21ccacae04f8050f5691d0dd8159fda1; the local checkout matches GitHub main.
Read-only GitHub API inspection on 2026-09-12:
GET /repos/basefoundry/base-cli-demo/rules/branches/main returns pull_request, deletion, and non_fast_forward rules. It has no required_status_checks rule, and required_approving_review_count is 0. The older branch-protection endpoint returns 404 because protection uses rulesets; this finding concerns missing required checks, not an unprotected branch claim.
Sources:
- .github/workflows/tests.yml
- .github/workflows/compatibility.yml
- .github/workflows/issue-branch-policy.yml
Acceptance criteria
- Require the main consumer test gate and minimum/latest supported installed-wheel compatibility checks, including branch-policy enforcement as appropriate.
- Use stable aggregate check names if matrix expansion makes individual names brittle.
- Read back the effective rules and demonstrate a failed required check prevents merge in a safe fixture/PR.
- Document any necessary solo-maintainer review exception without disabling test enforcement.
Project fields
- Status: Backlog
- Priority: P1
- Area: CI
- Initiative: Base-CLI Demo
- Size: S
- Assignee: @codeforester
- Milestone: v0.1.0
- Target date: unscheduled
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
ci: add stable consumer and compatibility gates (#39)
codeforester commentedon Oct 9, 2026
Updated the active Base default branch protection ruleset. It now requires required-consumer, required-compatibility, and base/issue-branch-policy, with strict up-to-date checks. Readback confirmed the effective ruleset. The current draft PR #48 has failing required-consumer and required-compatibility checks, so this issue remains open until a controlled PR/fixture verifies the failure-blocking behavior end to end.
codeforester commentedon Oct 9, 2026
Required-check gate completed. The active Base default branch protection ruleset now requires required-consumer, required-compatibility, and base/issue-branch-policy with strict up-to-date checks. Ruleset readback confirmed the configuration, and draft PR #48 currently reports failures on the required consumer and compatibility checks. Closing this configuration issue as completed; PR #48 remains open separately for the base-cli 0.5.0 migration.