ci: run aggregate BATS validation without terminal stdin - #539
Open
codeforester wants to merge 2 commits into
Open
codeforester wants to merge 2 commits into
codeforester wants to merge 2 commits into
Conversation
codeforester
commented
Oct 5, 2026
codeforester
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed against issue #536 and current head c462f11. The aggregate BATS stage is now detached from maintainer terminal stdin while explicit PTY helpers remain available for tests that require a TTY; the new PTY regression test verifies non-terminal stdin. Hosted checks are green (11 pass, 0 fail, 0 pending), and GitHub reports MERGEABLE/CLEAN with no conflicts. No blocking findings in this review. Issue #536 remains open. This PR is correctly stacked on #538, so it is not independently ready for main until its parent is integrated.
Base automatically changed from
ci/537-20261001-ci-isolate-release-artifact-tests-from-dirty-worktrees
to
main
October 5, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the aggregate validation gate deterministic when launched from an interactive terminal. The BATS stage now receives
/dev/nullas stdin, while tests that need a TTY continue to allocate one explicitly through their PTY helpers.Issue
Fixes #536
Validation
bats tests/validate-driver.bats </dev/null— 2/2 passed.git diff --checkpassed../tests/validate.sh </dev/null— 700 BATS tests and all subsequent validation stages passed.Demo Impact
None.
Docs Impact
None.
API Impact
None.
CI Impact
The canonical BATS invocation no longer inherits a maintainer terminal. This prevents timeout supervision and unavailable-terminal assertions from changing outcome based on how validation was launched.
Security Notes
None. The timeout supervisor continues to fail closed for direct foreground-TTY use.
Notes
This PR is intentionally based on #538 (
ci/537-20261001-ci-isolate-release-artifact-tests-from-dirty-worktrees) so the aggregate gate is validated with both fixes. Retarget tomainafter #538 lands.Checklist
<category>/<issue>-<YYYYMMDD>-<slug>for tracked work.Fixes #536.