Repository navigation
Adopt merge-blocking Bash validation and quality checks #540
Description
Activity
Implementation is in PR #551. It adds the fail-closed
Product validationandQuality contractcontexts, static CI-policy regression coverage, and the documented post-merge ruleset readback procedure. Local focused checks pass; hosted checks are still running. The full local suite reached all 708 BATS tests and Python contracts, then hit the existing sandboxed artifact-contract network fixture failure (api.github.testconnection reset). Live branch protection was intentionally not changed in this PR.Closeout evidence:
- PR ci: add fail-closed validation aggregates #551 (ci: add fail-closed validation aggregates #551) merged as f72059c.
- The effective main-branch ruleset now requires base/issue-branch-policy, Product validation, and Quality contract, all from integration 15368.
- PR docs: record active validation merge checks #563 (docs: record active validation merge checks #563) merged as 333cfb3 after its complete PR matrix passed.
- Post-merge main Tests run 37634682854 (https://github.com/basefoundry/base-bash-libs/actions/runs/37634682854) passed, including macOS, Ubuntu, compatibility, release-gate, downstream-demo, and Product validation. Post-merge Quality run 37634682973 (https://github.com/basefoundry/base-bash-libs/actions/runs/37634682973) and branch-policy run 37634683715 (https://github.com/basefoundry/base-bash-libs/actions/runs/37634683715) also passed.
- Classic branch protection readback retains strict checks, zero required approvals, admin enforcement, linear history, and disabled force-push/deletion; its classic required-context list is empty because the active ruleset is authoritative.
The documentation now describes these aggregate contexts as active merge-blocking gates. This issue is resolved.
Metadata
Metadata
Assignees
Type
Projects
- Status
Goal
Require the framework validation contract before merging main without adding an unavailable second-maintainer approval requirement.
Background
Engineering review of
a90aa1429647b6eb4820a01aabe37799ca55ad5eon 2026-10-03. Original developer checkouts were preserved.Live rulesets on 2026-10-03 require only
base/issue-branch-policy; classic branch protection has no product contexts. docs/ci-policy.md explicitly describes this as an intentional modest baseline, so this issue proposes a policy improvement rather than labeling the current configuration a defect. Tests and Quality already provide substantive Bash/runtime/release evidence.Scope
Introduce/select stable product-validation and quality contexts, enforce them after a successful trusted run, and update the documented policy.
Acceptance Criteria
Validation
Run workflow fixtures and hosted validation, then read back rulesets and classic branch protection. Record the before/after policy and explain intentionally advisory lanes.
Evidence
Dependencies
basefoundry/base#2451 — preserve existing repository controls before relying on additive policy reconciliation.
Non-Goals
No unrelated architecture rewrite, release publication, or automatic live repository-policy change as part of review intake. Implementation follows the issue-backed worktree and reviewed PR workflow.
Project Fields
Agent Assignment
Assignee: @codeforester. Policy-strengthening proposal: confirm the intended required lanes before implementation; no settings were changed by this review.