Skip to content

Pass the ACME cache path to kamal-proxy deploy - #2000

Open
kmc-agent wants to merge 1 commit into
mainfrom
proxy-ssl-acme-cache-path
Open

kmc-agent wants to merge 1 commit into
mainfrom
proxy-ssl-acme-cache-path

Conversation

@kmc-agent

@kmc-agent kmc-agent commented Nov 16, 2026 •

Copy link
Copy Markdown

kamal-proxy accepts --tls-acme-cache-path on deploy, but Kamal had no way to set it.

This adds a proxy.ssl_acme_cache_path setting that Kamal passes to kamal-proxy as --tls-acme-cache-path. When the setting is not present, the deploy command does not change.

proxy:
  ssl: true
  host: example.com
  ssl_acme_cache_path: /home/kamal-proxy/.config/kamal-proxy/certs

The path is inside the kamal-proxy container, so it must be on a persistent volume. A shared volume at this path lets multiple proxy instances share the Let's Encrypt certificates for the same domains. The configuration docs say both of these things.

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

The PR appears safe to merge.

Summary

Adds proxy.ssl_acme_cache_path and passes it to kamal-proxy deploy as --tls-acme-cache-path.

  • Proxy deploys pass a configured path to the ACME certificate cache.

No actionable issues found.

Reviews (1) · Last reviewed commit: "Pass the ACME cache path to kamal-proxy ..." · Reviewed by Greptile

Add a `proxy.ssl_acme_cache_path` setting that kamal-proxy receives as
`--tls-acme-cache-path`, to choose where it stores ACME assets.
Copilot AI balanced review requested due to automatic review settings November 16, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are reported for the custom ACME cache-path configuration change.

No open issues 🎉

What changed in this PR

Adds proxy.ssl_acme_cache_path so Kamal can pass a custom ACME certificate cache directory to kamal-proxy during deployment, without changing commands when the setting is omitted.

Changes:

  • Maps the new setting to --tls-acme-cache-path.
  • Documents container-relative paths, persistent storage, and shared-volume use.
  • Tests deploy options with and without the setting.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
test/​configuration/​proxy_test.rb Tests inclusion and omission of the cache-path option.
lib/​kamal/​configuration/​proxy.rb Passes the configured cache path to deploy options.
lib/​kamal/​configuration/​docs/​proxy.yml Documents the setting and persistent/shared storage requirements.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants