Repository navigation
Conversation
Add a `proxy.ssl_acme_cache_path` setting that kamal-proxy receives as `--tls-acme-cache-path`, to choose where it stores ACME assets.
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the custom ACME cache-path configuration change.
No open issues 🎉
What changed in this PR
Adds proxy.ssl_acme_cache_path so Kamal can pass a custom ACME certificate cache directory to kamal-proxy during deployment, without changing commands when the setting is omitted.
Changes:
- Maps the new setting to
--tls-acme-cache-path. - Documents container-relative paths, persistent storage, and shared-volume use.
- Tests deploy options with and without the setting.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
test/configuration/proxy_test.rb |
Tests inclusion and omission of the cache-path option. |
lib/kamal/configuration/proxy.rb |
Passes the configured cache path to deploy options. |
lib/kamal/configuration/docs/proxy.yml |
Documents the setting and persistent/shared storage requirements. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kamal-proxy accepts
--tls-acme-cache-pathondeploy, but Kamal had no way to set it.This adds a
proxy.ssl_acme_cache_pathsetting that Kamal passes to kamal-proxy as--tls-acme-cache-path. When the setting is not present, the deploy command does not change.The path is inside the kamal-proxy container, so it must be on a persistent volume. A shared volume at this path lets multiple proxy instances share the Let's Encrypt certificates for the same domains. The configuration docs say both of these things.


Confidence Score: 5/5 
The PR appears safe to merge.Summary
Adds
proxy.ssl_acme_cache_pathand passes it tokamal-proxy deployas--tls-acme-cache-path.No actionable issues found.
Reviews (1) · Last reviewed commit: "Pass the ACME cache path to kamal-proxy ..." · Reviewed by Greptile