fix: use latest builder and fix max account slots#170
Merged
Conversation
Build both base-reth-node and base-builder binaries from the same cargo build in build-base-reth-node.sh, removing the separate build-builder job and its associated build script, version inputs, and environment variables.
The base-reth-node client was missing the --txpool.max-account-slots flag that the reth client has, causing 'txpool is full' errors after only a few transactions from the same account.
Cache ~/bin/builder (post-rename) instead of ~/bin/base-builder so the builder artifact is available on cache hit. Update the cache key to invalidate the old cache that only contained base-reth-node.
Collaborator
✅ Heimdall Review Status
|
refcell
previously approved these changes
Mar 9, 2026
cb-heimdall
dismissed
refcell’s stale review
Approved review 3916906542 from refcell is now dismissed due to new commit. Re-request for approval.
meyer9
changed the title
refcell
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--flashblocks.fixedarg that was removedTesting