Chore lint#96
Conversation
There was a problem hiding this comment.
Copilot reviewed 67 out of 70 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "opentelemetry-exporter-otlp~=1.39.1", | ||
| "wrapt~=1.17.3", | ||
| "httpx>=0.28.1", | ||
| "black>=26.1.0", |
There was a problem hiding this comment.
The black dependency has been added to the project dependencies. However, Black is typically used as a development tool rather than a runtime dependency. Consider moving it to the dev optional dependencies group instead to keep the production installation lean.
| [tool.ruff] | ||
| line-length = 120 | ||
| target-version = "py310" | ||
| line-length = 160 |
There was a problem hiding this comment.
The line length has been increased from 120 to 160 characters. While this is a valid choice, it may cause readability issues on smaller screens and in code review tools. The Python community standard (PEP 8) recommends 79-99 characters. Consider if 160 is necessary or if 120 was more appropriate.
| ] | ||
|
|
||
| [[tool.hatch.envs.test.matrix]] | ||
| python = ["3.10", "3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
The Python 3.14 version is listed in the test matrix, but Python 3.14 has not been released yet (current stable is 3.13). This will cause CI failures. Remove 3.14 from the matrix until it's released, or use an alpha/beta version explicitly if testing against pre-release versions.
|
|
||
| # Add row asynchronously | ||
| row, warning = await client.add_row( | ||
| row = await client.add_row( |
There was a problem hiding this comment.
Variable row is not used.
| trace._TRACER_PROVIDER_SET_ONCE = trace.Once() | ||
| try: | ||
| trace.set_tracer_provider(original_provider) | ||
| except Exception: |
There was a problem hiding this comment.
'except' clause does nothing but pass and there is no explanatory comment.
No description provided.