Skip to content

fix: (get_prompt) handle model without top_k #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarquisG merged 1 commit into from
Dec 1, 2025
Merged

fix: (get_prompt) handle model without top_k #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions basalt/utils/dtos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
@dataclass
class PromptModelParameters:
temperature: float
top_k: float
top_k: Optional[float]
top_p: Optional[float]

frequency_penalty: Optional[float]
Expand All @@ -25,10 +25,10 @@ class PromptModelParameters:
def from_dict(cls, data: Dict[str, Any]):
return cls(
temperature=pick_number(data, "temperature"),
frequency_penalty=pick_number(data, 'frequencyPenalty') if data.get("frequencyPenalty") else None,
presence_penalty=pick_number(data, "presencePenalty") if data.get("presencePenalty") else None,
top_p=pick_number(data, "topP"),
top_k=pick_number(data, "topK") if data.get("topK") else None,
frequency_penalty=pick_number(data, 'frequencyPenalty') if data.get("frequencyPenalty") is not None else None,
presence_penalty=pick_number(data, "presencePenalty") if data.get("presencePenalty") is not None else None,
top_p=pick_number(data, "topP") if data.get("topP") is not None else None,
top_k=pick_number(data, "topK") if data.get("topK") is not None else None,
max_length=data["maxLength"],
response_format=pick_typed(data, "responseFormat", str),
json_object=data.get("jsonObject"),
Expand Down