Skip to content

fix mismatch get prompt params order #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarquisG merged 3 commits into from
Nov 24, 2025
Merged

fix mismatch get prompt params order #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77334bd
fix mismatch get prompt params order
MarquisG Nov 24, 2025
02f82a8
same for get_sync
MarquisG Nov 24, 2025
84f765d
review all prompts methods
MarquisG Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion basalt/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.5.0"
__version__ = "0.5.1"
12 changes: 6 additions & 6 deletions basalt/sdk/promptsdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from typing import Optional, Dict, Tuple, cast

from ..ressources.monitor.generation_types import GenerationParams, PromptReference
from ..ressources.monitor.trace_types import TraceParams
from ..ressources.prompts.prompt_types import Prompt as IPrompt, PromptParams
from ..utils.protocols import IPromptSDK
from ..utils.dtos import (
GetPromptDTO,
GetPromptResult,
Expand All @@ -28,7 +28,7 @@
from ..utils.flusher import Flusher
from datetime import datetime

class PromptSDK:
class PromptSDK(IPromptSDK):
"""
SDK for interacting with Basalt prompts.
"""
Expand All @@ -50,8 +50,8 @@ def __init__(
async def get(
self,
slug: str,
version: Optional[str] = None,
tag: Optional[str] = None,
version: Optional[str] = None,
variables: Optional[Dict[str, str]] = None,
cache_enabled: bool = True
) -> GetPromptResult:
Expand Down Expand Up @@ -111,8 +111,8 @@ async def get(
def get_sync(
self,
slug: str,
version: Optional[str] = None,
tag: Optional[str] = None,
version: Optional[str] = None,
variables: Optional[Dict[str, str]] = None,
cache_enabled: bool = True
) -> GetPromptResult:
Expand Down Expand Up @@ -210,8 +210,8 @@ def _prepare_monitoring(self,prompt: IPrompt,
async def describe(
self,
slug: str,
version: Optional[str] = None,
tag: Optional[str] = None,
version: Optional[str] = None,
) -> DescribeResult:
"""
Get details about a prompt by slug, optionally specifying version and tag.
Expand Down Expand Up @@ -250,8 +250,8 @@ async def describe(
def describe_sync(
self,
slug: str,
version: Optional[str] = None,
tag: Optional[str] = None,
version: Optional[str] = None,
) -> DescribeResult:
"""
Synchronously get details about a prompt by slug, optionally specifying version and tag.
Expand Down