Add test for start_observe with external parent span#102
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Merged
Co-authored-by: CorentinGS <43623834+CorentinGS@users.noreply.github.com>
Co-authored-by: CorentinGS <43623834+CorentinGS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on feat: examples pull request
Add test for start_observe with external parent span
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-span detection now treats
start_observespans as Basalt roots when a non-Basalt parent span exists (e.g., from FastAPI/httpx instrumentation). Existing tests didn't cover this case.Changes
test_start_observe_with_external_parent_span: Verifies thatstart_observecorrectly establishes a Basalt root when an external OpenTelemetry span exists as parent butROOT_SPAN_CONTEXT_KEYis not setThe test simulates the scenario where framework instrumentation creates a parent span, then asserts:
basalt.rootattribute is set toTrueROOT_SPAN_CONTEXT_KEYis attached to the context✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.