feat: save feed entry contents into topic contents#66
Open
julianlam wants to merge 2 commits intobarisusakli:masterfrom
Open
feat: save feed entry contents into topic contents#66julianlam wants to merge 2 commits intobarisusakli:masterfrom
julianlam wants to merge 2 commits intobarisusakli:masterfrom
Conversation
This change utilises the `content` property from rss-parser to populate the topic post content. That property contains HTML, so additional logic is present here to instruct the markdown plugin to ignore it. For versions of NodeBB that don't have an up-to-date Markdown plugin, the HTML will be parsed (and likely escaped), but admins can toggle "Allow HTML" to have it rendered properly.
Contributor
Author
That logic is only available in upcoming v4.0.0 but this plugin will not break on older versions, so it is safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change utilises the
contentproperty from rss-parser to populate the topic post content. That property contains HTML, so additional logic is present here to instruct the markdown plugin to ignore it. For versions of NodeBB that don't have an up-to-date Markdown plugin, the HTML will be parsed (and likely escaped), but admins can toggle "Allow HTML" to have it rendered properly.