feat: add linter - #433
Open
alex-messer wants to merge 9 commits into
Open
Conversation
alex-messer
marked this pull request as ready for review
November 12, 2024 16:55
alex-messer
marked this pull request as draft
November 12, 2024 16:55
ewoerner
force-pushed
the
main
branch
5 times, most recently
from
February 17, 2026 22:11
8faee5a to
2c306ad
Compare
…gration Brings the branch up to date with ~21 months of main (React Router v7, ESLint 9, Vite 8, map component refactor, etc.) and resolves the resulting conflicts: - Restore antd's Less-based theming (App.less + vite less options), which the branch had replaced with precompiled antd CSS, losing main's primary-color/dark-background/card padding overrides. - Reconcile package.json: keep main's dependency versions, keep the branch's husky/lint-staged/stylelint tooling, drop dead deps (redux-thunk, sass-migrator, simple-git-hooks). - Port main's post-divergence style changes (new CSS custom properties, color-mix() fixes, banner-card/banner-info-with-map tweaks) into their SCSS equivalents. - Rewrite UserBannerList.tsx from the class-based Redux component (which main had reintroduced via an earlier bad merge) to the modern functional/InfiniteBannerList pattern already used by Agent/Events. Also closes gaps left by the original Less->Sass conversion, found by diffing compiled CSS output against main's Less build: - .positive-action-button and .search-mission-list rules were dropped entirely (turned into an unreferenced mixin / omitted), breaking several buttons and the create-banner mission search layout. - override/_leaflet_override.scss existed but was never @use'd. - The pre-commit hook now actually runs lint-staged (it previously ran unstaged whole-project lint/stylelint commands). Fixed lint-staged's wiring so it invokes the CLIs directly instead of npm scripts that hardcoded their own file lists via bash-only syntax, which broke on Windows and double-appended files. - Added .stylelintignore for dist/ so a local build doesn't get linted. - Added tsconfig.node.json to eslint's project list so vite.config.ts resolves under lint-staged. - Fixed the stylelint violations left across files main touched after the branch diverged (property order, !important annotations, BEM/camelCase class names, duplicate keyframes, missing generic font-family) so `npm run stylelint` passes repo-wide.
Vite 8's SassPreprocessorOptions maps directly onto sass/sass-embedded's own StringOptions type, which has no api field now that the modern compiler API is the only one - api: 'modern-compiler' no longer exists on the type and failed tsc -p tsconfig.node.json.
…sion Found by diffing compiled CSS declarations against main's Less build, selector by selector: - BannerList.scss: .banner-list-entry lost its base width: 360px (only kept inside a mobile media query), so cards on the start page sized themselves off content instead of a fixed 360px column, making the 3-per-row grid wrap unpredictably to 2. Also restored the missing 296px width at the <=321px breakpoint. - _ant-override.scss: `body` was dropped from both grouped selectors, so the page background/font-size overrides no longer applied to the body element itself. - BannerCard.scss: .offline-overlay-line used rgba(var(--color-black), 0.7), which is invalid CSS (rgba() doesn't accept a single color argument), so the background silently failed to apply; switched to color-mix(). Also restored !important on .modal-image/.close-button rules needed to override antd's own modal styles. - CreateBanner.scss: restored !important on .ant-radio-group label's color, needed to override antd's radio button text color.
- Ensure map view state aligns with URL on navigation events (e.g., back/forward navigation) in `BannersMap`. - Introduce `syncViewFromLocation` and reconcile URL-driven banner selection in `MapOverview`. - Improve history state management with `lastAppliedSearch` tracking. - Allow `withRouter` to listen to the global router for unmount-triggered navigation events. - Refactor and centralize router instance handling. - Optimize `onPlaceSelected` in `Browser` to concurrently fetch children and banners.
KirDE
marked this pull request as ready for review
August 24, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#432