feat: isolate coding agent processes by room - #629
Open
AlexanderZ-Band wants to merge 10 commits into
Open
AlexanderZ-Band wants to merge 10 commits into
AlexanderZ-Band wants to merge 10 commits into
Conversation
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 12, 2026
AlexanderZ-Band
commented
Sep 13, 2026
AlexanderZ-Band
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review pass: fixed room-workspace ownership, removal of shared Codex fallback state, failed Codex startup cleanup, stale transport documentation, and focused regression coverage. The legacy ACP/Codex fixture suite still targets the intentionally removed shared-process and injected-client APIs; it remains the reason this PR stays draft.
AlexanderZ-Band
marked this pull request as ready for review
September 13, 2026 05:16
Extract shared workspace collision guard, DRY ACP profile resolution, and test helpers that patch per-room stdio spawns so legacy fixtures work without the removed shared-process APIs. Co-authored-by: Cursor <cursoragent@cursor.com>
Compare Codex thread cwd against resolved workspace paths and drop hardcoded Band URLs from the codex adapter quick-start snippet. Co-authored-by: Cursor <cursoragent@cursor.com>
AlexanderZ-Band
enabled auto-merge
September 14, 2026 12:36
AlexanderZ-Band
requested review from
amit-gazal-band,
bandzalkin and
nir-singher-band
and removed request for
amit-gazal-band,
bandzalkin and
nir-singher-band
September 15, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_for_room(room_id), defaulting to an isolated./.band-workspaces/<room-id>directory when unsetthread/start, not a sharedcwdValidation
uv run pytest tests/adapters/test_room_workspace_isolation.py -q— 4 passeduv run ruff check src/band/adapters/codex.py src/band/integrations/acp/client_adapter.py src/band/workspaces.py tests/adapters/test_room_workspace_isolation.py examples/codex/01_basic_agent.py examples/codex/02_tom_agent.py examples/codex/03_jerry_agent.py examples/run_agent.py examples/docker_demo/agents/dev/main.pyuv run pyrefly check src/band/adapters/codex.py src/band/integrations/acp/client_adapter.py src/band/workspaces.py tests/adapters/test_room_workspace_isolation.pypython -m compileallfor changed examplesgit diff --checkDraft gate
Legacy ACP/Codex fixture suites (
tests/adapters/test_codex_adapter.py,tests/integrations/acp/test_client_adapter.py,tests/integrations/acp/test_client_adapter_behavior.py) construct these adapters against the removed shared-process/injected-client APIs (cwd=,client_factory=,spawn_process=) and fail without a workspace-lifecycle migration: 143 failed / 58 passed in the Codex suite, 207 failed / 88 passed / 14 errors in the ACP suite. This PR stays draft until those fixtures move to room-owned stdio lifecycle equivalents.