1.进行iOS系统的适配 by liuxiaobai710189615 · Pull Request #1638 · banchichen/TZImagePickerController

liuxiaobai710189615 · 2023-03-08T13:03:13Z

2.FLAnimatedImage替换为最新代码，只做了const BOOL isGIFData = imageSourceContainerType ? UTTypeConformsTo(imageSourceContainerType, kUTTypeGIF) : NO; 判断改动 3.增加TZWindowManager，Window管理类

…or的iOS11的适配

…tionStatusForAccessLevel:PHAccessLevelReadWrite] iOS14.0判断

…ng for configuration named，解决

banchichen · 2023-03-08T13:59:24Z

TZImagePickerController/TZImagePickerController/TZImageManager.m

-                resultImage = [self fixOrientation:resultImage];
-                if (completion) completion(resultImage,info,NO);
-            }];
+            if (@available(iOS 13.0, *)) {


这个建议抽一个公共方法（可以就放TZImageManager里），这个公共方法里判断iOS13，其它地方调用这个公共方法，可以省许多if代码。现在到处if else，回调处理逻辑重复存在，比较杂乱

已经在TZImageManager 抽一个公共方法 requestImageDataFitSystemForAsset

banchichen · 2023-03-08T14:02:43Z

TZImagePickerController/TZWindowManager/TZWindowManager.m

+        UIWindowScene *curWinSc = (UIWindowScene *)tmpSc;
+        return curWinSc.keyWindow;
+    } else {
+        return [[[UIApplication sharedApplication] windows] objectAtIndex:0];


这里用第0个window代替keyWindow稳定吗？

已经在 TZCommonTools 中currentKeyWindow重新获取keyWindow

banchichen · 2023-03-08T14:06:26Z

TZImagePickerController/TZImagePickerController/TZImagePickerController.m

+                        [UIApplication sharedApplication].statusBarHidden = NO;
+                    }
+                }
+            }


为了兼容iOS9以下系统，要留这么一大段if的话，就不支持iOS9以下了吧...

要测试下，横竖屏切换是否会让状态栏显示哈，测试正常的话回复下哈

切换横屏不显示切换竖屏显示，在iOS13以后

iOS9以下代码删除

banchichen · 2023-03-08T14:09:25Z

TZImagePickerController/TZImagePickerController/TZImagePickerController.m

+        isStatusBarHidden = [[TZWindowManager manager] currentWindow].windowScene.statusBarManager.statusBarHidden;
+    } else {
+        isStatusBarHidden = [UIApplication sharedApplication].statusBarHidden;
+    }


这个和对requestImageDataAndOrientationForAsset的调用一样，建议抽成个公共方法，到处去判断太冗余了
可以放到TZCommonTools里

已经在 TZCommonTools 中currentStatusBarHidden 抽成个公共方法

banchichen · 2023-03-08T14:11:03Z

TZImagePickerController/TZImagePickerController/TZImagePickerController.m

-        if (CGRectEqualToRect(keyWindow.bounds, [UIScreen mainScreen].bounds)) {
-            window = keyWindow;
-        }
-    }


这段取window的逻辑，和[[TZWindowManager manager] currentWindow]不一样，直接替换可能有问题吧？

已经在 TZCommonTools 中currentKeyWindow重新获取keyWindow

banchichen · 2023-03-08T14:12:48Z

TZImagePickerController/TZImagePickerController/TZPhotoPreviewController.m

    CGFloat naviBarHeight = statusBarHeight + _tzImagePickerVc.navigationBar.tz_height;
    _naviBar.frame = CGRectMake(0, 0, self.view.tz_width, naviBarHeight);
-    _backButton.frame = CGRectMake(10, 10 + statusBarHeightInterval, 44, 44);
-    _selectButton.frame = CGRectMake(self.view.tz_width - 56, 10 + statusBarHeightInterval, 44, 44);


把10 + statusBarHeightInterval换成statusBarHeight的考虑是？

让左右两个 Button 对称

banchichen · 2023-03-08T14:15:10Z

TZImagePickerController/TZImagePickerController/TZImagePickerController.h

 #define CURRENT_SYSTEM_VERSION         [[UIDevice currentDevice] systemVersion]
 #define SYSTEM_VERSION_GREATER_THAN_15 ([CURRENT_SYSTEM_VERSION floatValue] >= 15.0)

-@class TZAlbumCell, TZAssetCell;


这里改成import TZAssetCell是？

Umbrella header for module 'TZImagePickerController' does not include header 'TZAssetCell.h'

banchichen · 2023-03-08T14:20:01Z

TZImagePickerController/TZImagePickerController/TZPhotoPreviewController.m

-    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didChangeStatusBarOrientationNotification:) name:UIApplicationDidChangeStatusBarOrientationNotification object:nil];
+}
+
+-(void)viewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id<UIViewControllerTransitionCoordinator>)coordinator {


注意风格哈，-后面有个空格

(void)

liuxiaobai710189615 added 6 commits March 8, 2023 20:30

1.进行iOS系统的适配

2d5f998

2.FLAnimatedImage替换为最新代码，只做了const BOOL isGIFData = imageSourceContainerType ? UTTypeConformsTo(imageSourceContainerType, kUTTypeGIF) : NO; 判断改动 3.增加TZWindowManager，Window管理类

1.statusBarStyle的样式,iOS系统适配

434baac

1.修改automaticallyAdjustsScrollViewInsets和contentInsetAdjustmentBehavi…

bbed97e

…or的iOS11的适配

1.[NSURL URLWithString:UIApplicationOpenSettingsURLString] iOS10系统的适配

c77c1cf

1.相册权限，[PHPhotoLibrary authorizationStatus]和[PHPhotoLibrary authoriza…

97f65fe

…tionStatusForAccessLevel:PHAccessLevelReadWrite] iOS14.0判断

1.iOS Info.plist contained no UIScene configuration dictionary (looki…

05c6fd3

…ng for configuration named，解决

banchichen reviewed Mar 9, 2023

View reviewed changes

liuxiaobai710189615 added 2 commits March 9, 2023 20:17

1.iOS9以下代码删除，iOS13适配完毕

b1ed376

1.iOS14 获取相册权限的判断

c54ab77

Conversation

liuxiaobai710189615 commented Mar 8, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants