feat: allow choosing another printer when printing files from printer storage - #11746
Open
jactan77 wants to merge 1 commit into
Open
feat: allow choosing another printer when printing files from printer storage#11746jactan77 wants to merge 1 commit into
jactan77 wants to merge 1 commit into
Conversation
… storage Previously the printer combobox in SelectMachineDialog was unconditionally disabled when printing a file from a printer's storage (FROM_SDCARD_VIEW), so when the source printer was busy there was no way to print the job on another idle printer. Now the printer list stays enabled in this mode. When a different printer is selected, Studio downloads the .gcode.3mf from the source printer (via PrinterFileSystem, with progress and cancel support in the dialog) and sends it to the selected printer through the regular upload path (new PrintJob type "from_sdcard_transfer", LAN FTP with cloud fallback), keeping the plate index, AMS mapping and print options. Sending to the source printer itself keeps the existing sdcard-print behavior. The printer-model mismatch warning now also covers cross-printer sends.
jactan77
force-pushed
the
feat/sdcard-print-printer-switch
branch
from
July 28, 2026 19:33
4eb47c7 to
2766dbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When printing a file from a printer's storage (device page → files / print history → Print), the printer combobox in
SelectMachineDialogis unconditionally disabled (FROM_SDCARD_VIEWmode). If the source printer is busy, the dialog shows "The printer is busy on other print job" and there is no way to print the job on another idle printer — the printer list cannot even be expanded.Solution
FROM_SDCARD_VIEWmode (it is only disabled when the source printer's file system is not available).start_sdcard_print, the printer prints its local file)..gcode.3mffrom the source printer viaPrinterFileSystem(progress + cancel supported in the dialog's status bar, previously downloaded files are reused), then sends it to the selected printer through the regular upload path — newPrintJobtypefrom_sdcard_transfer(LAN FTP with cloud fallback), preserving the plate index, AMS mapping and print options.MediaFilePanelpasses the source printer's file system, file index and dev id to the dialog via a newPlater::set_sdcard_print_source().Testing status
BuildLinux.sh -s); no new compiler warnings in the touched files.