Guard PIN-code backspace focus - #11709
Draft
BenJule wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the PIN-code dialog from focusing before the first input field when Backspace is pressed.
Root cause
PingCodeBindDialog::on_key_backspace()acceptedidx == 0and unconditionally focusedm_text_input_single_code[idx - 1]from a deferredCallAftercallback.Pressing Backspace in the first PIN field could therefore access the input array with index
-1, causing undefined behavior.Change
Only move focus to the preceding PIN field when the current index is greater than zero. The confirm button is still disabled for Backspace in every valid field.
Validation
idx - 1accessgit diff --checkBindDialog.cppsyntax check when a matching compile database entry is availableNo local full build was performed. Full application validation remains delegated to Jenkins.