matching literal pattern when no lang or datatype#4
Open
dougli1sqrd wants to merge 1 commit intobalhoff:masterfrom
Open
matching literal pattern when no lang or datatype#4dougli1sqrd wants to merge 1 commit intobalhoff:masterfrom
dougli1sqrd wants to merge 1 commit intobalhoff:masterfrom
Conversation
cmungall
reviewed
Aug 24, 2017
cmungall
left a comment
cmungall
left a comment
There was a problem hiding this comment.
does arachne ever reason with datatypes?
Not really sure of the consequences of changing the defaults here
balhoff
reviewed
Aug 24, 2017
| case BlankNode(id) => factory.createBNode(id) | ||
| case org.geneontology.rules.engine.Literal(value, _, Some(lang)) => factory.createLiteral(value, lang) | ||
| case org.geneontology.rules.engine.Literal(value, uri @ org.geneontology.rules.engine.URI(_), _) => factory.createLiteral(value, uriFromArachne(factory, uri)) | ||
| case org.geneontology.rules.engine.Literal(value, _, _) => factory.createLiteral(value) |
Owner
There was a problem hiding this comment.
I don't think it's possible to reach this pattern.
Owner
|
No, Arachne doesn't do any reasoning with datatypes yet. Basically we just want to try to avoid accidentally creating duplicate triples when translating back and forth from sesame. I think we need to make the datatype URI optional in Arachne. @dougli1sqrd I think we should probably just fix that in Arachne. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.