Repository navigation
security: publier Gestion 3.4.9 sans identifiants de secours dans les tests - #702
Merged
Merged
Conversation
This was referenced Nov 13, 2026
baimard
marked this pull request as ready for review
November 13, 2026 18:27
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Les scénarios JsTest.php et initAppTest.php exigent NEXTCLOUD_TEST_USER et NEXTCLOUD_TEST_PASSWORD avant tout navigateur, avec une URL locale par défaut. Aucun compte de secours n’est utilisé. Sans configuration complète, PHPUnit ignore le scénario et le script autonome s’arrête. Trois tests de non-régression et les vérifications réseau désactivé couvrent ces protections.
La CI exécute explicitement Controller, Bdd et Service. Cette couverture a révélé un appel de test retiré dans Nextcloud 34 : les quatre fixtures concernées utilisent désormais l’API publique OCP\Server et IDBConnection. Le manifeste et les versions npm passent à 3.4.9 pour la publication du correctif. Le déclencheur Qonto reste en 3.4.8 afin de préserver l’acquittement des utilisateurs.
Validation locale : trois tests de protection réussis (six assertions), six configurations absentes ou partielles et deux configurations explicites vérifiées sans réseau, syntaxe PHP et construction Sphinx stricte réussies. La matrice Nextcloud 32 à 35 est relancée avec toutes les suites. Documentation dans #704.
Les anciennes valeurs ne sont ni reproduites ici ni testées. Elles restent dans l’historique Git ; si elles correspondent à un compte actif, le mot de passe doit être changé.
Closes #701.