CARCADE Refactor 3: Treat Action (+params and tests)#175
Open
allison-li-1016 wants to merge 42 commits intomainfrom
Open
CARCADE Refactor 3: Treat Action (+params and tests)#175allison-li-1016 wants to merge 42 commits intomainfrom
allison-li-1016 wants to merge 42 commits intomainfrom
Conversation
Contributor
Author
|
Jannetty
requested changes
Apr 29, 2025
cainja
requested changes
May 1, 2025
Member
cainja
left a comment
There was a problem hiding this comment.
I will revisit tests when we address some of the comments. I imagine they will lead to fairly large changes to the tests.
allison-li-1016
commented
Jun 12, 2025
cainja
reviewed
Jul 6, 2025
Member
cainja
left a comment
There was a problem hiding this comment.
please add an example input file/user interface for the treat action in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Time: Medium
Summary: Adding
TreatAction class, and associated parameters and tests. TheTreatAction will add CAR T-cell agents of specified dose and ratio next to source points or vasculatureExample Input: