Skip to content

CARCADE Refactor 3: Treat Action (+params and tests)#175

Open
allison-li-1016 wants to merge 42 commits intomainfrom
allison/carcade-refactor-treat
Open

CARCADE Refactor 3: Treat Action (+params and tests)#175
allison-li-1016 wants to merge 42 commits intomainfrom
allison/carcade-refactor-treat

Conversation

@allison-li-1016
Copy link
Copy Markdown
Contributor

@allison-li-1016 allison-li-1016 commented Apr 21, 2025

Review Time: Medium

Summary: Adding Treat Action class, and associated parameters and tests. The Treat Action will add CAR T-cell agents of specified dose and ratio next to source points or vasculature

Example Input:

<action id="TREAT" class="treat">
     <action.parameter id="TIME_DELAY" value="0" />
     <action.parameter id="DOSE" value="1500" />
     <action.register id="CD8" />
     <action.register id="CD4" />
 </action>

@allison-li-1016 allison-li-1016 self-assigned this Apr 21, 2025
@allison-li-1016 allison-li-1016 marked this pull request as draft April 21, 2025 17:13
@allison-li-1016 allison-li-1016 changed the title CARCADE Refactor 3: Treat Action CARCADE Refactor 3: Treat Action (+params and tests) Apr 22, 2025
@allison-li-1016 allison-li-1016 marked this pull request as ready for review April 23, 2025 17:21
@allison-li-1016 allison-li-1016 requested review from a team, Jannetty, cainja, daniellevahdat, jacob-evarts, jessicasyu and pohaoc2 and removed request for a team April 23, 2025 17:21
@allison-li-1016
Copy link
Copy Markdown
Contributor Author

  1. Tests
  • Don't test private values
  1. Use enums to handle states
  2. Don't use 4 array lists just use 1 data structures

Copy link
Copy Markdown
Member

@cainja cainja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revisit tests when we address some of the comments. I imagine they will lead to fairly large changes to the tests.

@allison-li-1016 allison-li-1016 marked this pull request as ready for review July 1, 2025 16:37
Copy link
Copy Markdown
Member

@cainja cainja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an example input file/user interface for the treat action in the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants