feat: schedule/calendar write by EveGun · Pull Request #69 · bacnet-js/client

EveGun · 2026-02-19T07:00:12Z

Summary

This PR ports schedule/calendar write compatibility from the legacy node-bacstack implementation into @bacnet-js/client, and adds write examples for manual validation.

Source reference:

https://github.com/EveGun/node-bacstack

What changed

Added specialized encode paths in WriteProperty.encode for:
WEEKLY_SCHEDULE
EXCEPTION_SCHEDULE
EFFECTIVE_PERIOD
DATE_LIST
Added dedicated payload encoders in src/lib/services/WriteProperty.ts for weekly schedule, exception schedule, effective period, and calendar date list.
Added stricter validation before encoding:
weekly schedule must have exactly 7 day arrays
exception schedule priority must be in range 1..16
DATERANGE entries must contain exactly 2 dates
WEEKNDAY values are validated (including wildcard 0xff)
raw date byte input (year/month/day/wday) is validated
Added write examples:
examples/write-schedule-weekly.ts
examples/write-schedule-exception.ts
examples/write-schedule-period.ts
examples/write-calendar-datelist.ts
Updated example CLI behavior so target accepts host[:port], with optional local bind port as separate argument.
Added/extended unit tests in test/unit/service-write-property.spec.ts for schedule/calendar write compatibility and failure cases.

Type consistency

Kept the existing public writeProperty contract unchanged.
Invalid payloads now fail fast with explicit validation errors instead of encoding malformed APDUs.

Validation

npm run lint ✅
npm run test:unit ✅
Docker-based compliance tests executed successfully in local environment ✅
Manually validated against a WAGO PFC200 device ✅

Notes

Manually validated write behavior against WAGO PFC200 schedule/calendar objects. Full roundtrip tested.
Emulator-related legacy hacks are intentionally not included in this PR.
Schedule/calendar compatibility payloads are currently supported in writeProperty only. writePropertyMultiple is unchanged and does not yet support these specialized payload shapes.
This is the same PR as i closed. The issues I was investigating came from the decoder, not the encoder. Separate PR follows

…payloads

…ding

…r write examples

…erties

…stead of hex substring

…ot timestamp

…assertions

…tructure assertions

robertsLando · 2026-02-19T07:27:49Z

@EveGun changes look good to me, let's see if copilot detects something :) Thanks for your PRs 🙏🏼

Copilot

Pull request overview

This PR adds support for writing BACnet schedule and calendar properties (WEEKLY_SCHEDULE, EXCEPTION_SCHEDULE, EFFECTIVE_PERIOD, and DATE_LIST) to the @bacnet-js/client library. The implementation ports functionality from the legacy node-bacstack library, adding specialized encoding paths for these complex property types that require custom payload structures beyond simple application data arrays.

Changes:

Added specialized encoding methods in WriteProperty service for schedule/calendar properties with validation
Introduced new TypeScript types for schedule/calendar payload structures in src/lib/types.ts
Added comprehensive unit tests covering both successful encoding and validation failure scenarios
Provided four example files demonstrating write operations for each supported property type

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`src/lib/services/WriteProperty.ts`	Core implementation with specialized encoding methods and validation logic for schedule/calendar properties
`src/lib/types.ts`	New type definitions for schedule/calendar payload structures
`src/lib/client.ts`	Updated signature to accept new payload types
`test/unit/service-write-property.spec.ts`	Added 19 new test cases covering encoding and validation
`examples/write-schedule-weekly.ts`	Example demonstrating weekly schedule write
`examples/write-schedule-exception.ts`	Example demonstrating exception schedule write
`examples/write-schedule-period.ts`	Example demonstrating effective period write
`examples/write-calendar-datelist.ts`	Example demonstrating calendar date list write

examples/write-schedule-weekly.ts

examples/write-schedule-period.ts

examples/write-schedule-exception.ts

examples/write-calendar-datelist.ts

src/lib/services/WriteProperty.ts

examples/write-calendar-datelist.ts

…perty

…in exception dates

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

src/lib/services/WriteProperty.ts

src/lib/types.ts

…gth check

…ngth check

…iteration

…ding

… encoding

Accept BACnet DATE day marker values (32/33/34) in generic DATE encoding and schedule/calendar WriteProperty encoding. Add focused unit tests for both code paths.

Extend existing day-marker tests to assert support for BACnet raw DATE day values 32, 33 and 34 in both generic ASN.1 app-data encoding and WriteProperty exception schedule encoding.

robertsLando · 2026-02-23T08:08:52Z

@EveGun I see you marked this as draft now, was it intended?

EveGun · 2026-02-23T08:58:14Z

@robertsLando Yes, but ready again now.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

src/lib/services/WriteProperty.ts

EveGun · 2026-02-25T08:22:31Z

@robertsLando maybe run CI again? Looks like coveralls failed at some external http calls.

robertsLando · 2026-02-25T08:48:49Z

@EveGun Coveralls it's failing in many others projects I own, seems it's an issue with their server so no issues here 🙏🏼

robertsLando

LGTM. Well done! 💪🏼

EveGun added 14 commits February 17, 2026 14:10

feat(write): add schedule/calendar write compatibility and examples

3f99c41

chore(examples): default local write port to 47808

a773e19

fix(write): enforce strict schedule/calendar input validation

7ebf25d

fix(write): harden schedule/calendar validation and document example …

d2c6eea

…payloads

fix(write-property): validate exception schedule priority before enco…

1cc682f

…ding

fix(write-property): validate WEEKNDAY values before encoding

2a81359

fix(write-property): enforce two-date DATERANGE in calendar DATE_LIST

6364545

fix(examples): use host[:port] target and optional local bind port fo…

9481f40

…r write examples

fix(types): add typed write payload unions for schedule/calendar prop…

4d8f649

…erties

fix(types): align date/time app-data typing with write payload handling

db073fd

test(write-property): validate weekly schedule payload via decoder in…

9ed629d

…stead of hex substring

fix(write-property): treat ZERO_DATE wildcard by sentinel identity, n…

2ba8d1e

…ot timestamp

test(write-property): validate exception schedule payload via decode …

a50ac13

…assertions

test(write-property): verify calendar DATE_LIST payload via decoded s…

bbe826b

…tructure assertions

robertsLando requested a review from Copilot February 19, 2026 07:27

Merge branch 'master' into feature/schedule-calendar-write

54826c6

Copilot started reviewing on behalf of robertsLando February 19, 2026 07:27 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

EveGun added 3 commits February 19, 2026 11:06

refactor(write-property): deduplicate date-range encoding in WritePro…

912653b

…perty

fix(write-property): support BACnet even/odd month wildcard encoding …

0cb4e44

…in exception dates

style(test): format write-property date marker case for prettier

dad9608

robertsLando requested a review from Copilot February 19, 2026 15:41

Copilot started reviewing on behalf of robertsLando February 19, 2026 15:41 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

robertsLando and others added 5 commits February 19, 2026 16:48

Merge branch 'master' into feature/schedule-calendar-write

82ced5a

fix(write-property): validate weekly schedule payload type before len…

b651808

…gth check

fix(write-property): validate exception schedule arrays before iteration

df952f5

fix(write-property): validate effective period payload type before le…

8fed444

…ngth check

fix(write-property): validate calendar date list payload type before …

bdfe1e9

…iteration

EveGun added 5 commits February 23, 2026 08:09

fix(asn1): support numeric and raw DATE/TIME in generic app-data enco…

83f5535

…ding

fix(asn1): reject invalid numeric TIME timestamps in generic app-data…

7676c7c

… encoding

fix(asn1): allow BACnet raw DATE day markers 32-34

0743287

Accept BACnet DATE day marker values (32/33/34) in generic DATE encoding and schedule/calendar WriteProperty encoding. Add focused unit tests for both code paths.

test(asn1): cover raw DATE day markers 32-34

026c14c

Extend existing day-marker tests to assert support for BACnet raw DATE day values 32, 33 and 34 in both generic ASN.1 app-data encoding and WriteProperty exception schedule encoding.

style(prettier): format asn1 and write-property tests to satisfy lint

02ebfa7

EveGun marked this pull request as draft February 23, 2026 08:05

Merge branch 'master' into feature/schedule-calendar-write

d1b0a9c

EveGun marked this pull request as ready for review February 23, 2026 08:57

robertsLando requested a review from Copilot February 23, 2026 09:33

Copilot started reviewing on behalf of robertsLando February 23, 2026 09:33 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

EveGun added 3 commits February 24, 2026 12:37

fix(write-property): validate schedule time inputs before encoding

a5f9797

refactor(write-property): tighten schedule payload typings safely

2753f16

refactor(write-property): tighten date/time typing and raw date handling

b81515b

robertsLando requested changes Feb 24, 2026

View reviewed changes

src/lib/services/WriteProperty.ts Outdated Show resolved Hide resolved

refactor(write-property): extract reusable object/type-value guards

2f974bd

robertsLando approved these changes Feb 25, 2026

View reviewed changes

robertsLando merged commit 82a060a into bacnet-js:master Feb 25, 2026
8 of 9 checks passed

Conversation

EveGun commented Feb 19, 2026

Summary

What changed

Type consistency

Validation

Notes

Uh oh!

robertsLando commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertsLando commented Feb 23, 2026

Uh oh!

EveGun commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EveGun commented Feb 25, 2026

Uh oh!

robertsLando commented Feb 25, 2026

Uh oh!

robertsLando left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants