keep hidden state of container children on copy/move/localize/copyToLanguage - #763
Open
achimfritz wants to merge 2 commits into
Open
keep hidden state of container children on copy/move/localize/copyToLanguage#763achimfritz wants to merge 2 commits into
achimfritz wants to merge 2 commits into
Conversation
DataHandler::copyRecord() forces hidden=1 on every copied record unless the backend user has neverHideAtCopy enabled. Our own copy/move hook for container children relied on that default, so all children ended up hidden after copying a container, regardless of their original visibility. Pass the source child's hidden value explicitly as an override in the cmdmap's update array, which takes precedence over DataHandler's automatic hideAtCopy logic. Relates to: #400
…nguage Same issue as the copy/move fix, but 'localize' and 'copyToLanguage' cmdmap commands don't support an 'update' override array, so the hidden value can't be passed through the cmdmap directly. Instead, restore it explicitly via a follow-up datamap call once the new child record's uid is known. Fixes: #400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.