fix: preserve empty platform discovery configuration - #185
Open
Gambit-Checkmate wants to merge 1 commit into
Open
Gambit-Checkmate wants to merge 1 commit into
Gambit-Checkmate wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #183.
Only fall back to the top-level OpenTDF configuration when the nested
configurationvalue is missing orNone. An explicitly empty configuration now stays empty instead of allowing unrelated outeridporplatform_issuerfields to affect discovery.The existing discovery error is preserved for an empty configuration. This does not add new response-type validation or change the handling of nonempty nested, top-level, or explicit-null configurations.
Tests
Add eight parameterized regression cases:
AutoConfigureException, leave the token endpoint unset, and make no additional HTTP discovery request. Both cases fail with the original code.Local validation on Windows, Python 3.12.10, using the frozen dependency lock:
ruff checkandruff format --check: passed.twine checkpassed for both artifacts.git diff --check: passed.The Docker-backed platform integration tests were not run locally because the Docker daemon is unavailable. The existing CI workflow covers those tests on Python 3.10–3.14.
AI assistance was used to implement, review, and test this contribution.