Repository navigation
Conversation
The stdin=true parameter in the exec URL caused the SPDY connection to close when stdin sent EOF (from io.NopCloser). Removing stdin from both the URL and StreamWithContext fixes the capture. Also increased ephemeral container wait timeout from 30s to 120s for clusters that need to pull the debug image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The exec stream wasn't producing any data. When spe created an ephemeral container and exec'd tcpdump into it, the pcap file was always 0 bytes, even though tcpdump was running and traffic was flowing.
Root cause
The
Execmethod hadstdin=truein the URL parameters. WhenStreamWithContextwas called withio.NopCloser(bytes.NewReader(nil))as stdin, the SPDY connection received EOF on stdin immediately, which caused the connection to close before any stdout data could flow.Fix
stdin=truefrom theExecURL parameters ininternal/k8s/client.goStdinfrom theStreamWithContextcall ininternal/capture/ephemeral.goTesting
Verified on kind cluster: