Repository navigation
MCP: offer client roots so servers can write files - #139
Merged
Merged
Conversation
MCPManager(roots:) declares the MCP `roots` capability and answers
roots/list with the given folders. chrome-devtools-mcp refuses every
file path outside the client's roots ("is not within any of the
configured workspace roots"), so take_screenshot's filePath failed for
every location the agent picked. Empty roots keep the old behavior.
Live test checks both ways: with a root the screenshot is written; with
none the server returns the access-denied error.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCPManager(roots:)declares the MCProotscapability and answersroots/listwith the given folders.Why: chrome-devtools-mcp only writes files (e.g.
take_screenshotfilePath) inside the client's roots. With none offered, every path failed with "is not within any of the configured workspace roots", and agents burned many calls on workarounds.roots(the default) keeps the old behavior — no capability declared.file://directory URIs.SAK_LIVE_TESTS=1): chrome-devtools-mcp--isolated --headlesswrites a screenshot inside an offered root; verified the same test fails with the access-denied error when no roots are offered.🤖 Generated with Claude Code