XIVY 18080 SqlExecutor#271
Draft
ivy-tgr wants to merge 1 commit into
Draft
Conversation
ivy-tgr
force-pushed
the
XIVY-18080-SqlExecutor
branch
3 times, most recently
from
42f637a to
150d131
Compare
ivy-edp
reviewed
Jul 2, 2026
ivy-edp
left a comment
ivy-edp
left a comment
Member
There was a problem hiding this comment.
Good. I think we should add a note that this tool should not be used against a production database, since it allows execution of any sql queries. At the very least, we should include a more prominent warning that the executor can run any SQL statement. @ivy-rew what do you think? Something looking like that:
Member
good point, yes we should raise a warning banner here. |
ivy-tgr
force-pushed
the
XIVY-18080-SqlExecutor
branch
from
150d131 to
6f1b2b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.