refactor: split rank-E report and snapshot helpers#1196
Closed
axisrow wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Дубликат партии 1 #1131 — та же работа (split _publish_snapshots + _build_report) уже смержена через #1197 (commit 7a9ef80). Этот PR открыл воркер -7 перед зависанием; работа была забрана оркестратором, провалидирована (AST-эквивалентность + 72 теста + dual-review Claude+Codex APPROVE) и смержена как #1197 без одноразового AST-скрипта (он засорял ruff). Закрываю как superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1131
Summary
src/runtime/worker.py::_publish_snapshotsinto private snapshot/payload helpers while preserving snapshot publish order and the chore(worker): не спамить полным трейсбэком при таймауте снапшота нотификейшн-бота #1172asyncio.TimeoutErrornotification-bot branch.ChannelAnalyzer._build_reportinto fetch/build/flag/report helper methods while preserving flag ordering and report construction.scripts/verify_refactor_ast_equivalence.pyto compare the extracted helper composition againstorigin/mainAST blocks.Code health delta
Before
python scripts/code_health.py --top 40:A:3483 B:502 C:221 D:34 E:8 F:0, average3.46._publish_snapshotsE(40),ChannelAnalyzer._build_reportE(32).After
python scripts/code_health.py --top 40:A:3506 B:507 C:221 D:34 E:6 F:0, average3.44.radon cc -s src/runtime/worker.py src/filters/analyzer.py:_publish_snapshotsA(1),ChannelAnalyzer._build_reportA(2).AST proof
python scripts/verify_refactor_ast_equivalence.py --base-ref origin/mainpassed.Validation
ruff check src/ tests/ conftest.pypassed.pytest tests/test_runtime_worker.py -vpassed:19 passed.pytest tests/test_filters.py -vpassed:53 passed.pytest tests/test_db_access_conventions.py tests/test_test_levels.py -qpassed:17 passed.pytest tests/ -v -m aiosqlite_serialpassed:943 passed, 9266 deselected.pytest tests/ -v -m "not aiosqlite_serial" -n autocompleted but failed outside this refactor scope: 7 failures intests/test_quality_scoring_service.py,tests/routes/test_debug_routes.py::test_debug_memory_returns_json, andtests/test_pipelines.py::test_pipelines_page_renders.