fix(pool): synchronize teardown lease releases#1193
Merged
axisrow merged 1 commit intoJun 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_clientteardown cleanup through_lease_pool.release(phone)while holdingClientPool._lock.disconnect_alltimeout force-cleanup through_lease_pool.release(phone)while holdingClientPool._lock._acquire_from_leasenon-shared failure cleanup through_lease_pool.release(phone)while holdingClientPool._lock._lease_pool.releaseand assertClientPool._lockis held at the release/discard point.Validation
pytest tests/test_client_pool_lifecycle.py -vpassed.pytest tests/test_main_client_pool_collector_paths.py::TestClientPoolProperties::test_remove_client -vpassed.ruff check src/ tests/ conftest.pypassed.pytest tests/ -v -m aiosqlite_serialpassed: 941 passed, 9242 deselected.pytest tests/ -v -m "not aiosqlite_serial" -n autowas run after the main fix. It exposed one local test-double update, now fixed and verified, plus unrelated provider/env failures intests/test_quality_scoring_service.pyandtests/test_pipelines.pycaused by live/default provider behavior and unclosed socket warnings in this environment.Closes #1191