Show next ariring Ep in userAnimelist [for v3.8.0] #403
Open
blackholeearth wants to merge 7 commits intoaxiel7:masterfrom
Open
Show next ariring Ep in userAnimelist [for v3.8.0] #403blackholeearth wants to merge 7 commits intoaxiel7:masterfrom
blackholeearth wants to merge 7 commits intoaxiel7:masterfrom
Conversation
Delete MainNavigation.kt.rej show_NextAiringEp_inUserAnimeList also available on Std , Min , and GridView * add anilist id secret to buildconfig field also need to add them in to private rproperties. but interestly , id secret is not needed when using Anilist public urls (non user list editing api Endpoints) ---------------- show_NextAiringEp_inUserAnimelist some fixes + clean up branch show_NextAiringEp_inUserAnimelist show_NextAiringEp_inUserAnimelist_viaAnilist_v2 Ep 8 in 2 days based on moelist 371
blackholeearth
changed the title
blackholeearth
changed the title
Contributor
Author
|
We can make this optional . İn setting. İf you prefer that. What do you say..? |
blackholeearth
changed the title
blackholeearth
changed the title
blackholeearth
changed the title
blackholeearth
force-pushed
the
show_NextAriringEP_inUserList__for_v380__cherrypick
branch
2 times, most recently
from
02e1056 to
b7b0550
Compare
fix private.properties names backto main repo back to privateProps at build.gradle
to keep Original Proj Clean
----------
factor out my code - from axiel's view - as much as possible
min compatct std UMediList item , remove comments
animerepository remove comments.
remove comments whitespaces.
clean up comments UMListViev
app.kt minimize my code
Update CompactUserMediaListItem.kt
Update CompactUserMediaListItem.kt
clear compact imports
update gui from UM_ListView with event.onItemSelected
it can now update gui from UserMediaListView with event?.onItemSelected.
----------
it was really frustrating, until i found the exact event.
BUG-FIX: usermedilist item - longTap wrong info bug fixed
if i call AddNextAiringEpInfo_Compose inside UserMedialistView.kt
it opens WRONG dialog , SORT button does wrong this. ALL ui event fucks up.
-------
safe bet is to move it back to anime repository.
1st app run it add 500-700ms extra time.
next time 1ms , cuz its cached in the KACHE.
fixed endless loop
found BUG - coundt fix - calling getairingnifo_compose repeatedly.
i have 3 item in my list , now there is a bug .
it calls compose again and again endless loop.
Update UserMediaListView.kt
--------------------
fix missing {,} at AnilistQuery -- caused deleting getAiringxxxxxxSharedFlow func
my func humanradable time - bug fix
remove comments at unused code of mine remove comments at unused code of mine Update UserMediaListView.kt comment unsued code remove comments delete unused buggy compose comment out unsused constants delete unused files networkmodule globalvarialbes reduce comment safest way to get data into model . is HERE .. WHY put it HERE?? previosly tried to do it in compose view.. but it created infinite loop.. thats why i gave up.. do it like this.
blackholeearth
force-pushed
the
show_NextAriringEP_inUserList__for_v380__cherrypick
branch
from
b7b0550 to
d3a6d4e
Compare
Revert "Delete .gitignore" This reverts commit 689147b.
blackholeearth
force-pushed
the
show_NextAriringEP_inUserList__for_v380__cherrypick
branch
from
77ae27f to
6f00e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello axiel.
i have rebased this feature to v3.8.0 .
Made it clean as possible.
i only modified 1 single line in your views. (4 files . standart ,compact , grid view etc... )
i put my 2 new files grapql.Anilist code into folders /GithubPR/ folder..
mimium invasion.
WHY this again.?
its painful to move code to next version everytime. v371 to v3.8 etc.
hope to see this. merged...