Open
Conversation
… used. We changed our internal PublishReturn constructor which required changes
bretambrose
reviewed
Mar 16, 2026
| * @param pubackControlHandle An opaque handle obtained from {@link PublishReturn#acquirePubackControl()}. | ||
| * @throws CrtRuntimeException If the native client returns an error when invoking the PUBACK. | ||
| */ | ||
| public void invokePuback(Mqtt5PubackControlHandle pubackControlHandle) throws CrtRuntimeException { |
Contributor
There was a problem hiding this comment.
Why the exception specification?
| * Native code sets [0] to 0 after the callback returns (via SetLongArrayRegion, | ||
| * requiring no extra JNI method ID). | ||
| */ | ||
| private final long[] nativeContextPtrHolder; |
Contributor
There was a problem hiding this comment.
I don't understand why this complexity is necessary. The acquire method is synchronized.
| } | ||
|
|
||
| /* Make the PublishReturn struct that will hold all of the data that is passed to Java */ | ||
| /* Create manual PUBACK control context (valid only during this callback) |
Contributor
There was a problem hiding this comment.
Let's discuss this tomorrow. I think there are a lot of ways to simplify this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind manual puback
Opaque manual puback control handle
Tests for Manual Puback
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.