Conversation
azkrishpy
commented
Feb 25, 2026
azkrishpy
commented
Feb 27, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 79.72% 79.75% +0.02%
==========================================
Files 28 28
Lines 11894 12015 +121
==========================================
+ Hits 9483 9583 +100
- Misses 2411 2432 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
azkrishpy
commented
Feb 27, 2026
azkrishpy
commented
Feb 27, 2026
azkrishpy
commented
Feb 28, 2026
TingDaoK
reviewed
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
c7b318c to
af32dd9
Compare
azkrishpy
commented
Mar 2, 2026
azkrishpy
commented
Mar 2, 2026
|
|
||
| struct aws_h1_encoder_message encoder_message; | ||
| ASSERT_SUCCESS(aws_h1_encoder_message_init_from_request(&encoder_message, allocator, request, &chunk_list)); | ||
| ASSERT_SUCCESS( |
Contributor
Author
There was a problem hiding this comment.
should we switch to having encoder options instead of adding more parameters?
azkrishpy
commented
Mar 2, 2026
TingDaoK
reviewed
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
A new protocol-agnostic aws_http_stream_write_data() API that lets users write request body data the same way regardless of whether the connection is HTTP/1.1 or HTTP/2.
High level details of changes:
Public API:
H1 Content-Length path:
H1 Chunked path:
H2 path:
Vtable unification:
Elasticurl example:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.