Skip to content

Add city parameter to weather tool#1303

Merged
akshseh merged 1 commit intoawslabs:mainfrom
ktzouvanaws:improve/add-parameters-in-agent-tools
Apr 10, 2026
Merged

Add city parameter to weather tool#1303
akshseh merged 1 commit intoawslabs:mainfrom
ktzouvanaws:improve/add-parameters-in-agent-tools

Conversation

@ktzouvanaws
Copy link
Copy Markdown
Contributor

Amazon Bedrock AgentCore Samples Pull Request

Important

  1. We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
  2. Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number: 1302

Concise description of the PR

City parameter is added to the weather tool, and prompts are adjusted so that it is excibited, how the Agent is able to extract name of the city in the prompt and execute the method, correctly passing the parameter. Method documentation is updated, 
so that Agent can understand the tool and use it properly.

User experience

Please share what the user experience looks like before and after this change
Prior to the change, users executing the notebook, would see the Agent calling a tool that
accepts no parameters and returns a hardcoded string. This oftenly resulted in user frustraction
as it is presented how the Agent extracts and passes parametes to tools.

Now they will see the Agent identifying the parameter and correctly passing it to the tool.

As this notebook is used in deep dive official agent core workshop, often customers
would harsly critisize the implementation due to the lack of parameters.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • Add your name to CONTRIBUTORS.md
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you uploading a dataset?
  • [] Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • I agree to resolve any issues created for this example in the future.
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added 01-tutorials 01-tutorials 01-AgentCore-runtime 01-tutorials/01-AgentCore-runtime labels Apr 10, 2026
@akshseh akshseh merged commit 65664ff into awslabs:main Apr 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01-AgentCore-runtime 01-tutorials/01-AgentCore-runtime 01-tutorials 01-tutorials

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants