Fixed intermittent pydantic validation error in canonical evaluator#119
Open
panasenco wants to merge 1 commit intoawslabs:mainfrom
Open
Fixed intermittent pydantic validation error in canonical evaluator#119panasenco wants to merge 1 commit intoawslabs:mainfrom
panasenco wants to merge 1 commit intoawslabs:mainfrom
Conversation
panasenco
force-pushed
the
fix-reasoning-none-validation-error
branch
from
d04107e to
4b9e581
Compare
…y fixing _extract_content_from_xml to return "" instead of None for missing elements.
panasenco
force-pushed
the
fix-reasoning-none-validation-error
branch
from
4b9e581 to
a6a6c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _extract_content_from_xml method in the canonical evaluator was returning None for missing XML elements.
When the evaluator's LLM didn't include
<thinking></thinking>tags in its response, this caused a pydantic validationerror because TestResult.reasoning expects a string, not None.
Should resolve #98 - certainly resolved that bug for me. I went from experiencing it 30% of the time to not at all.
Changes made
Changed line 90 in src/agenteval/evaluators/canonical/evaluator.py:
Before:
After:
Tests Updated
(None, None)to expect("", "")<thinking>tags scenario that was causing the bugBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.