Add timeout to final mount.nfs4 fall-through attempt#348
Open
vmishra22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The fall-through final mount attempt in
mount_nfs()callsproc.communicate()without a timeout. When the FSS data plane intermittently drops connections, the kernelmount.nfs4syscall withhard,timeo=600,retrans=2can block this final attempt for 5+ minutes before returning ETIMEDOUT.This fix applies the same timeout (
retry_nfs_mount_command_timeout_sec, default 15s) to the final attempt as is used in the bounded retry loop.The retry loop at
call_nfs_mount_command_with_retry_succeed()runsretry_count - 1bounded attempts. After they fail, the code falls through to an unbounded final attempt. With the defaultretry_count=3, worst-case mount time was previously unbounded; now it's(retry_count - 1) * timeout + final_timeout= ~45s by default.