Skip to content

Fix incorrect typescript types#699

Open
gordonmleigh wants to merge 1 commit into
aws:masterfrom
gordonmleigh:fix-types
Open

Fix incorrect typescript types#699
gordonmleigh wants to merge 1 commit into
aws:masterfrom
gordonmleigh:fix-types

Conversation

@gordonmleigh

Copy link
Copy Markdown

Issue #, if available: #450

Description of changes:

The types are wrong because the javascript exports the functions using module.exports = function and the types declare a named export.

Fixed according to Definitely Typed Best Practices, using export = ....

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gordonmleigh
gordonmleigh requested a review from a team as a code owner November 25, 2024 15:59
@codecov-commenter

codecov-commenter commented Dec 2, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.56%. Comparing base (3b89008) to head (afd3bc7).
⚠️ Report is 70 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          36       36           
  Lines        1813     1813           
=======================================
  Hits         1515     1515           
  Misses        298      298           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants